Skip to content

[lua][module] Modules to revert spells to their in era behavior#137

Open
CriticalXI wants to merge 1 commit into
phoenixffxi:betafrom
CriticalXI:era_magic_potencies
Open

[lua][module] Modules to revert spells to their in era behavior#137
CriticalXI wants to merge 1 commit into
phoenixffxi:betafrom
CriticalXI:era_magic_potencies

Conversation

@CriticalXI

Copy link
Copy Markdown
Member

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  • Temporarily exposes spell tables to module over, plan to rework once LSB magic tables either have been exposed or magic itself has been re-organized
  • Adds several modules to adjust Ninjutsu, Enhancing, Enfeebling, and Songs to have their in era potency, duration, or behavior
  • Also implements merit rank adjustments back into spells that were taken out of merits

Steps to test these changes

  • Read the modules, try out the described logic changes

@CriticalXI
CriticalXI force-pushed the era_magic_potencies branch from c7bb7e5 to 5447d15 Compare July 23, 2026 15:37
@CriticalXI CriticalXI added the hold Do not merge this PR label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Do not merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant