Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades Terra Core to the
v2.21release, built on Cosmos SDK v0.53.7, IBC-Go v10.7.0, wasmd v0.60.7 and alliance v0.5.1. The IBC v10 migration removes thecapabilitymodule and the29-fee(ICS-29) module, and this release also drops async-icq.A
v2.21upgrade handler is registered under the plan namev2.21; it runs module migrations only.Dependency bumps
phoenix-directivefork)phoenix-directivefork)cometbft stays at v0.38.21. Transitive
cosmossdk.io/*modules move with SDK v0.53 (x/txv0.14,x/upgradev0.2.0,collectionsv1.3.1,apiv0.9.2).Breaking changes
Removed modules
capability— removed by IBC v10.CapabilityKeeper, allScopedKeepers, the capability store key + mem store key, andCapabilityKeeper.Seal()inNewTerraAppare gone (app/keepers/keepers.go,app/keepers/keys.go,app/app.go,app/modules.go).29-fee(ICS-29) —IBCFeeKeeper, module registration, store key and module account removed.async-icq— the ICQ module, keeper, store key, module account, genesis defaults and theicqAllowedQueries()allow-list (~170 lines ofapp/genesis.go) are removed, along withQueryICQParamsinapp/config/const.goand the ICQ proto path inscripts/protoc-swagger-gen.sh.Keeper wiring
ibckeeper.NewKeeper,ibctransferkeeper.NewKeeperandpacketforwardkeeper.NewKeepernow take aruntime.KVStoreServiceinstead of a raw store key; transfer takes theMsgServiceRouterin place of the port/scoped keepers.ibctm.NewAppModule(app.Keepers.TMLightClientModule)).x/wasm/keeper.NewKeeperdrops theportKeeperandcapabilityKeeperarguments (wasmd v0.60 signature).Module ordering
preBlockersOrder(upgrade,auth) wired viaapp.mm.SetOrderPreBlockers.capability,ibcfeeandicqremoved from init-genesis / begin-blocker / end-blocker orders.Test plan
make test/ unit + simulation tests passyarn test:chain:upgrade:v21upgrade simulation from a v2.20 statemake test-e2e-pmfinterchaintest suite