fix: add CancellationToken to Command Execute methods - #17
Merged
Merged
Conversation
Spectre.Console.Cli v0.53.1 changed the Command<T> base class to require a CancellationToken parameter in the Execute method signature. Update all four command classes to match the new abstract method.
…erlet The coverage job was using `dotnet run -- --coverage` flags which are not recognized by the xUnit v3 Microsoft Testing Platform runner. Switch to `dotnet test --collect:"XPlat Code Coverage"` with coverlet.collector package, which is the standard approach for collecting code coverage with xUnit v3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Command<T>.Executenow requires aCancellationTokenparameterFileCommand,FolderCommand,ProjectCommand,SolutionCommand) to match the new abstract method signatureTest plan
dotnet build --configuration Release