Skip to content

chore: docs and cleanup - #31

Merged
phine-lukas merged 8 commits into
mainfrom
chore-docs-and-cleanup
Sep 8, 2026
Merged

phine-lukas merged 8 commits into
mainfrom
chore-docs-and-cleanup

Conversation

@phine-lukas

@phine-lukas phine-lukas commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Open-source readiness pass for phine.af: polishes the public face (README, badges, docs link, CAMARA APIs table), adds contribution scaffolding (CONTRIBUTING with DCO sign-off, issue templates), sweeps stale OAI references out of our code/config/paths (upstream OAI submodule and OAI compose demos intentionally kept), consolidates the logging config schema without changing runtime behavior, re-syncs the architecture diagram, and unifies all first-party image names under the phinetech/phine.af-* prefix.

Related Issues

Related to: #13

Changes Made

  • Added

    • CONTRIBUTING.md — DCO sign-off requirement and draft-PR-first workflow.
    • .github/ISSUE_TEMPLATE/ — Bug Report, Feature Implementation, Task/Scope templates + config.yml (disables blank issues, links to docs & discussions).
    • README.md — CI / Apache-2.0 / CAMARA-compliant badge row, link to https://af.phine.tech/, and a CAMARA APIs table (QoD → camaraproject/QualityOnDemand).
    • Clarifying YAML comments on the legacy logging: blocks pointing at [TECH DEBT] Restore and enhance logging infrastructure #13.
  • Changed

    • Terminology sweep across docs and diagram: "Northbound Adapters" → "Northbound APIs" (reserving "Adapter" for the client-side /adapters/* demos).
    • docs/diagrams/architecture.mmd updated and re-synced into README.md and docs/architecture/overview.md via build/scripts/sync_diagrams.sh.
    • docs/index.md and docs/architecture/repository-layout.md rewritten to match the current layout; stale TODO markers cleared across ~9 doc pages.
    • docs/reference/configuration-reference.md and docs/development/configuration.md rewritten to explain the modern vs. legacy schema and Compose mount points.
    • config/af.yaml — de-duplicated nef_handler: / udr_handler: blocks.
    • Image names unified under the phine.af-* family in compose.yaml, docker-compose/compose*.yaml, .github/workflows/publish.yml, and README build examples:
      • phinetech/pcf-handler → phinetech/phine.af-pcf-handler
      • phinetech/af-core → phinetech/phine.af-core
      • phinetech/af-api → phinetech/phine.af-api
      • phinetech/af-demo-qod → phinetech/phine.af-demo-qod
      • phinetech/demo-qod-adapter → phinetech/phine.af-demo-qod-adapter
      • phinetech/af (bundled) → phinetech/phine.af
    • Runtime path sweep in Dockerfiles, src/main.cpp, af_core/, northbound/api_component/, southbound/pcf_handler/, adapters/demo-qod-adapter/, config/**, docker-compose/conf/**:
      • /var/log/oai/af/* → /var/log/phine.af/*
      • /etc/oai/af/* → /etc/phine.af/*
    • .github/PULL_REQUEST_TEMPLATE.md — dropped inapplicable OAI/Free5GC test-env rows.
  • Fixed

    • Duplicated nef_handler: / udr_handler: blocks in config/af.yaml.

Testing

  • Unit tests pass locally
  • Integration tests pass locally
  • Manually tested the changes
  • Added new tests for the changes

Notes:

CI/CD Status

  • Build Status: Will be checked automatically
  • Integration Tests: Will run automatically on PR update
  • Security Scan: Will run automatically

@phine-lukas phine-lukas self-assigned this Aug 28, 2026
@phine-lukas phine-lukas added the documentation Improvements or additions to documentation label Aug 28, 2026
@phine-lukas
phine-lukas force-pushed the chore-docs-and-cleanup branch 2 times, most recently from 880736a to 3f279bb Compare August 31, 2026 12:55
@phine-lukas
phine-lukas marked this pull request as draft August 31, 2026 14:40
@phine-lukas
phine-lukas force-pushed the chore-docs-and-cleanup branch from 3f279bb to 784ed6b Compare August 31, 2026 14:58
@phine-lukas
phine-lukas marked this pull request as ready for review August 31, 2026 15:00
@phine-lukas
phine-lukas force-pushed the chore-docs-and-cleanup branch from dab27da to ed47a0d Compare August 31, 2026 15:39
Add CONTRIBUTING (DCO sign-off, draft-PR workflow) and issue templates; polish README with badges, docs link (af.phine.tech) and CAMARA APIs table. Sweep OAI leftovers from our code, config and paths (/var/log/oai/af → /var/log/phine.af, /etc/oai/af → /etc/phine.af); rename "Northbound Adapters" → "Northbound APIs" and unify images + containers under the phine.af-* family. Consolidate logging config (file sink tracked in #13).

Co-authored-by: Cloude Opus 4.7
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
Bypass fragile llvm.sh script in Dockerfiles to prevent Cloudflare HEAD request failures (exit code 4) during clang-tidy installation.

Co-authored-by: Gemini 3.1 Pro
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
@phine-lukas
phine-lukas force-pushed the chore-docs-and-cleanup branch from a39c96b to e85fa03 Compare September 1, 2026 10:59
Delete the workflow_call-only integration-tests.yml (never wired into ci.yml) and the ci_helper.sh functions that referenced the missing docker-compose-test.yaml. Point docs/getting-started/02-build.md at build_standalone (matches its --clean/--debug/--tests flags) and switch 08-demo-adapter-tutorial.md's CI Quick Run to the same runme invocation test-tutorials.yml uses.

Assisted-by: Claude Opus 4.7
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
- Bump actions/checkout v4 → v5 and actions/upload-artifact v4 → v5
  across all workflows to move off the deprecated Node 20 runtime.
- Bump github/codeql-action/upload-sarif v2 → v3 (v1/v2 deprecated).
- Add security-events: write permission to the Trivy security-scan
  job so SARIF upload works once CodeQL is enabled post-open-sourcing;
  resolves 'Resource not accessible by integration' errors.

Assisted-by: Claude Opus 4.7
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
@phine-lukas
phine-lukas force-pushed the chore-docs-and-cleanup branch from 1bbf4d7 to c8b9350 Compare September 1, 2026 14:02
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
…SSWORD secrets

Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
Signed-off-by: Lukas Rotheneder <lukas.rotheneder@phine.tech>
@tariromukute
tariromukute self-requested a review September 8, 2026 15:10
@phine-lukas
phine-lukas merged commit a0a8f56 into main Sep 8, 2026
34 of 36 checks passed
@phine-lukas
phine-lukas deleted the chore-docs-and-cleanup branch September 8, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants