Repository navigation
test(routing): use the real clock for the routed-session backlog check - #26
Merged
Merged
Conversation
Routing stamps `session_topics.created_at` with the real time, but the test built the backlog with a fixed 2026-09-29 clock. From 30 Sep the routed sessions looked like they were in the future and were dropped. Production uses the real clock on both sides and is unaffected. Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_route_sessions_writes_model_routes_and_builds_backlogstarted failing on 30 Sep. Routing stampssession_topics.created_atwith the real time, but the test built the backlog with a fixed2026-09-29 12:00clock. Once the real date passed that, routed sessions looked like they were in the future, and the backlog dropped them.Change
The test builds the backlog with
datetime.now(timezone.utc), the same clock routing uses. Production already uses the real clock on both sides, so there's no code change.Verification
All 15 routing tests pass, and the full suite passes in the pre-commit hook. Ruff is clean.
This pull request and its description were written by Isaac.