Emods ijmodified#155
Open
glelouet wants to merge 6 commits into
Open
Conversation
added 6 commits
June 5, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step forward in the effort to add modern-ish (come on, enumset are soo 2000 ) code. No removal, just adding simpler methods to do the same thing.
The new addEmod method automatically discards invalid modifiers (like public for a local variable) and removes the ones excluded by those added :
Typically calling
Will result in the jmethod having PROTECTED modifier, with PRIVATE and PUBLIC removed if they were present ; the addition of SEALED is discarded, other existing modifiers are kept.
side note : final and volatile should also be in the list of mutual exclusion. The code style wrecks if I add them so I opt out (I added them, then realized there was too many changes so reverted the project and did it again. Took me 1h to try to fix it, before I gave up).
This means a variable should be removed volatile when set to final (which has no effect since vars can't be volatile ) ; and same for a field (which allows both, so effect)