Audit Ofox provider catalog - #1871
Open
DanielButler1 wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 162 files, which is 62 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (162)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f6daafd75
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "effective_to": null, | ||
| "capabilities": [ | ||
| { | ||
| "capability_id": "audio.transcription", |
There was a problem hiding this comment.
This newly active audio.transcription capability is the only active Ofox capability without a corresponding pricing/ofox/openai-gpt-transcribe/audio.transcription/pricing.json file; the other 142 capability entries have matching pricing records. Consequently, catalog consumers will expose GPT Transcribe as available through Ofox but cannot display its published rate, despite this change claiming complete pricing coverage. Add the missing pricing record or omit the route until its price is known.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L16
Useful? React with 👍 / 👎.
| "is_active_gateway": false, | ||
| "quantization_scheme": null, | ||
| "input_modalities": "text", | ||
| "output_modalities": "text", |
There was a problem hiding this comment.
This route declares embedding.generate with the OpenAI embeddings format, but labels its output as text; the two OpenAI embedding routes added later in this file have the same mismatch. Provider-model output modalities are used by catalog filtering and API responses, so these embedding routes will be advertised under text output instead of embeddings, unlike established embedding routes such as Voyage and OpenAI.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L16
Useful? React with 👍 / 👎.
Comment on lines
+2783
to
+2787
| "params": [ | ||
| "temperature", | ||
| "top_p", | ||
| "max_tokens", | ||
| "stop" |
There was a problem hiding this comment.
The embedding route advertises temperature, top_p, max_tokens, and stop, which are text-generation controls rather than parameters of the OpenAI-compatible embeddings endpoint; the two OpenAI embedding routes repeat the same list. Clients relying on this capability metadata can therefore send unsupported fields while missing actual embedding controls such as dimensions or encoding format. Record only the parameters supported by Ofox's embeddings endpoint.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L16
Useful? React with 👍 / 👎.
| "openai.responses", | ||
| "openai.images", | ||
| "openai.embeddings", | ||
| "openai.audio.transcriptions" |
There was a problem hiding this comment.
The provider-level format list ends without ofox.videos, although eight newly added active routes declare that format. This leaves the provider metadata inconsistent with its callable catalog and causes consumers inspecting api_formats to conclude that Ofox has no video API despite the newly documented video routes.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L15
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm validate:datapnpm validate:pricingpnpm validate:gatewaygit diff --checkNotes
pnpm openapi:genwas attempted, but the fresh worktree does not have local generation dependencies installed (rimrafunavailable). It made no tracked changes.Created with Codex