Audit IonRouter provider catalog - #1849
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 25 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (47)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d4719ce6b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "formats": [ | ||
| "openai" | ||
| ], | ||
| "endpoint": "https://glm.ionrouter.io/v1/chat/completions", |
There was a problem hiding this comment.
For glm-5 requests, the gateway executor calls resolveIonRouterUrlProvider, but apps/api/src/providers/ionrouter/config.ts only handles Kimi and MiniMax specially and otherwise selects https://api.ionrouter.io; it therefore never uses the newly verified https://glm.ionrouter.io endpoint. Calls requiring this model-specific host will be sent to the wrong server, so add the GLM configuration/resolver mapping or retain the general endpoint if that is actually authoritative.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L17-L18
Useful? React with 👍 / 👎.
| "provider_api_model_id": "ionrouter:voxtral-mini-4b", | ||
| "provider_model_slug": "voxtral-mini-4b", | ||
| "internal_model_id": "mistral/voxtral-mini-4b", | ||
| "is_active_gateway": true, |
There was a problem hiding this comment.
When mistral/voxtral-mini-4b is requested through IonRouter, this new active route has no matching pricing/ionrouter/.../text.generate/pricing.json anywhere in the catalog. The gateway explicitly removes candidates without pricing in apps/api/src/pipeline/before/index.ts, recording pricing_missing, so the newly advertised route cannot execute; add its pricing card or leave it inactive until pricing is available.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L18
Useful? React with 👍 / 👎.
| "output_modalities": "text", | ||
| "context_length": null, | ||
| "max_output_tokens": null, | ||
| "max_output_tokens": 128000, |
There was a problem hiding this comment.
For IonRouter's qwen2.5-7b route, this raises max_output_tokens to 128,000 even though the canonical models/qwen/qwen2.5-7b/model.json records an 8,192-token output limit. The imported provider route will consequently advertise a limit the underlying model cannot satisfy, causing oversized requests to reach the provider rather than being constrained consistently; use the provider-supported output limit instead.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L14-L16
Useful? React with 👍 / 👎.
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@phaseo/catalog": patch | |||
There was a problem hiding this comment.
This changeset names @phaseo/catalog, but no workspace package has that name; the catalog package declares @phaseo/data-catalog in packages/data/catalog/package.json. Changesets cannot apply this release entry to the intended package, so catalog versioning/release processing will fail or omit the change until the package name is corrected.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L34-L34
Useful? React with 👍 / 👎.
1 participant
Summary
/v1/modelsresponse as of 2026-08-24Reconciliation
voxtral-mini-4bandqwen3-vl-30b-a3bare retained alongside the docs catalog)Validation
pnpm validate:datapnpm validate:pricingpnpm validate:gatewaypnpm data:check-manifestgit diff --checkCreated with Codex