Reconcile Hugging Face router metadata - #1841
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (70)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f89ab50ee
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "api_model_id": "inclusionAI/Ling-2.6-1T", | ||
| "provider_api_model_id": "huggingface:inclusionAI/Ling-2.6-1T", |
There was a problem hiding this comment.
When this catalogue is imported, provider_api_model_id is the route’s persistent key and api_model_id participates in pricing and public-model lookups, while the case-sensitive upstream identifier already has a dedicated home in provider_model_slug. Replacing the lower-case IDs here creates new route identities for 30 Hugging Face records, removes the old identities during synchronization, and violates the catalogue’s lower-case slug contract; keep the stable api_model_id/provider_api_model_id values and apply Hub casing only to provider_model_slug.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L9-L9
Useful? React with 👍 / 👎.
| "prompt_training_source_url": null, | ||
| "zero_data_retention": "unknown", | ||
| "residency_source_url": "https://huggingface.co/docs/inference-providers/security", | ||
| "prompt_training_policy": "no_training", |
There was a problem hiding this comment.
no_training is not a valid catalogue policy value: the shared type and gateway/UI normalizers recognize no_train, may_train, opt_out_available, enterprise_no_train, or unknown. Consequently this newly verified policy is persisted as an unsupported raw value and normalized back to unknown by consumers, so Hugging Face will not appear under the intended no-training policy; use the schema-supported value appropriate to the external-provider boundary.
AGENTS.md reference: packages/data/catalog/AGENTS.md:L8-L10
Useful? React with 👍 / 👎.
1 participant
Summary
hf-inferenceserverless service and dedicated Inference EndpointsReconciliation
hf-inferenceremains separate; its 14 documented task families are recorded in the audit ledger and are not mislabeled as Router chat modelsReproducibility
node scripts/audit-huggingface-router.mjspackages/data/catalog/src/data/api_providers/huggingface/router-audit-2026-08-24.jsonValidation
node scripts/audit-huggingface-router.mjs— 130 live, 130 catalogued, 130 ledger, no missing/stale entriespnpm validate:datapnpm validate:pricingpnpm validate:gatewaygit diff --checkCreated with Codex