Repository navigation
Make inspector buttons respond to clicks - #20
Merged
phalladar merged 2 commits intoNov 6, 2026
Merged
Conversation
Inside the inspector, a SwiftUI ScrollView draws its content below the toolbar but hit-tests it without that offset, so a click landed about a toolbar's height above what was drawn and Reveal in Finder and Copy Path never fired. A List hit-tests its rows where they are drawn. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
horus-leonardo
force-pushed
the
fix/inspector-button-clicks
branch
from
November 3, 2026 20:45
1ee4582 to
eae0656
Compare
A List insets its rows by 8 pt, so the panel's side margins dropped from 16 pt to 8 pt. Add 8 pt of horizontal padding to restore them. The click bug only occurs on macOS 27 in builds that record SDK 15 (local SwiftPM builds). Builds stamped as SDK 26 or 27, like CI's, handle clicks with the ScrollView too, so say that in the comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks @horus-leonardo, merged! I confirmed the bug and pushed one small follow-up commit (1c963ec) on top of yours before merging:
What I found while verifying, on macOS 27 with synthesized clicks every 3 pt down the inspector:
I also added a short note with these results to the top of the description. Your commit went in as-is, so it's credited to you. Thanks for tracking this down! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer update: Verified on macOS 27 by clicking every 3 pt down the inspector with synthesized mouse events. With the
ScrollView, builds that record SDK 15 (local SwiftPM builds) never fire either button. The same code stamped as SDK 26 or 27, the way CI builds releases, works, so release downloads weren't affected. ThisListversion works in both. It does change the layout a little: the List's 8 pt row inset narrowed the side margins (restored in 1c963ec with 8 pt of horizontal padding), and the size values now sit at the right edge.Inside the inspector, the SwiftUI
ScrollViewdrew its content below the toolbar but hit-tested it without that offset. A click landed about a toolbar's height above what was drawn, so Reveal in Finder and Copy Path never fired. Clicking roughly 50 pt above a button did trigger it. Swapping theScrollViewfor a plainListwith hidden separators and background fixes it without visible changes.Validation
swift buildandswift testpass.🤖 Generated with Claude Code