parser.hpp: make compatible with modules#16
Merged
Conversation
`parse_bool` is referenced from `env::variable_id` via some other types.
If I now have
```c++
module;
#include <libenvpp/env.hpp>
export module testModule;
export
{
template <typename VarType, bool Required>
struct EnvironmentVariableBase
{
env::variable_id<VarType, Required> m_id;
}
}
```
I export a type that references a TU local definition in its template instantiation, which is invalid c++ and causes gcc to crash (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125356).
inline is enough here and also prevents binary bloat since only one definition is created for every TU that includes `env.hpp`.
Member
|
Thanks. I'll create a new release at some point soon with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_boolis referenced fromenv::variable_idvia some other types. If I now haveI export a type that references a TU local definition in its template instantiation, which is invalid c++ and causes gcc to crash (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=125356). inline is enough here and also prevents binary bloat since only one definition is created for every TU that includes
env.hpp.