Add PostgreSQL 19 compatibility#33
Open
sibowu-aws wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PG19 made two changes that broke pg_bigm's existing PG18 fallback for
t_isspace() (originally added in commit which copied the PG17
implementation after PG18 removed t_isspace via core commit d3aad4ac57c - postgres/postgres@d3aad4a):
information now lives on pg_locale_t->ctype_is_c, retrievable
via pg_database_locale().
(it was made static in src/backend/utils/adt/pg_locale_libc.c).
Add a PG_VERSION_NUM >= 190000 branch to t_isspace() that uses the new
public API: pg_database_locale() for the locale, pg_mb2wchar_with_len()
to decode the multibyte character, and pg_iswspace() for the classify
call. This mirrors the pattern PG19 itself uses in
src/backend/tsearch/ts_locale.c for t_isalnum / t_isalpha. The PG18
code path is preserved unchanged.
Also add alternate expected outputs (expected/pg_bigm_2.out,
expected/pg_bigm_ja_2.out) so the regression suite passes on PG19,
where:
(SET errors out, and the dependent \-escape tests behave
differently under standard strings).
line from HINT to DETAIL with a new message.
The original expected files are kept, so PG <= 18 continues to pass.