Replace mblen() with bounds-checked versions.#32
Open
MasahikoSawada wants to merge 1 commit into
Open
Conversation
Malformed or corrupted strings could cause code iterating with pg_mblen() to overrun its buffer. This commit replaces calls to pg_mblen() and t_isspace() with bounds-checked versions, such as pg_mblen_with_len() and t_isspace_with_len(). For backward compatibility with legacy releases (PostgreSQL 13 and earlier), provide shims that map these new APIs to the traditional un-checked implementations. Inspired by pg_trgm changes in commit 319e8a64419a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed or corrupted strings could cause code iterating with pg_mblen() to overrun its buffer. This commit replaces calls to pg_mblen() and t_isspace() with bounds-checked versions, such as pg_mblen_with_len() and t_isspace_with_len().
For backward compatibility with legacy releases (PostgreSQL 13 and earlier), provide shims that map these new APIs to the traditional un-checked implementations.
Inspired by pg_trgm changes in commit 319e8a64419a.