Skip to content

ci: add --check-cache to yarn install in CI workflows - #10392

Open
dev-hari-prasad wants to merge 1 commit into
pgadmin-org:masterfrom
dev-hari-prasad:ci/enable-yarn-check-cache
Open

ci: add --check-cache to yarn install in CI workflows#10392
dev-hari-prasad wants to merge 1 commit into
pgadmin-org:masterfrom
dev-hari-prasad:ci/enable-yarn-check-cache

Conversation

@dev-hari-prasad

@dev-hari-prasad dev-hari-prasad commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Part of #10363 (Item 6 from the tracking table).

As Dave noted in the issue discussion, yarn install --check-cache is a stronger form of cache and lockfile verification in CI.

Instead of just checking that the lockfile is self-consistent and trusting whatever is already in the runner's disk cache, --check-cache tells Yarn to re-verify the cached archives against the registry checksums to catch any cache tampering or poisoned archives.

Changes

  • Added --check-cache to yarn install across the 4 GitHub Actions workflows:
    • check-javascript-style.yml
    • run-javascript-tests.yml
    • run-feature-tests-epas.yml
    • run-feature-tests-pg.yml

Summary by CodeRabbit

  • Chores
    • Updated automated JavaScript checks and feature-test workflows to validate the Yarn cache during dependency installation.
    • Workflows now fail when cached dependencies are incomplete, stale, or corrupted.

Pass --check-cache to yarn install in GitHub Actions workflows to verify that cached package archives match the remote registry checksums, protecting against cache poisoning or corrupted cached packages.
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 7d22d100-3914-4352-b21d-c7e7d559217e

📥 Commits

Reviewing files that changed from the base of the PR and between bd7cde5 and 7654842.

📒 Files selected for processing (4)
  • .github/workflows/check-javascript-style.yml
  • .github/workflows/run-feature-tests-epas.yml
  • .github/workflows/run-feature-tests-pg.yml
  • .github/workflows/run-javascript-tests.yml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


Walkthrough

Four GitHub Actions workflows now run yarn install --check-cache to verify cached dependencies during JavaScript setup.

Changes

Workflow cache integrity

Layer / File(s) Summary
Yarn cache verification
.github/workflows/check-javascript-style.yml, .github/workflows/run-feature-tests-epas.yml, .github/workflows/run-feature-tests-pg.yml, .github/workflows/run-javascript-tests.yml
The workflows now use yarn install --check-cache during JavaScript dependency installation.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 76548

CI now validates cached JavaScript dependencies during installs in the style, JavaScript test, and feature-test workflows, failing on corrupted or inconsistent cache entries. No current merge-blocking risk is identified.

Suggested reviewers: dpage

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding --check-cache to yarn install in CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant