Skip to content

Bumps PG minor update server and spock versions.#20

Merged
maqeel75 merged 2 commits into
mainfrom
pg-may-updates
May 18, 2026
Merged

Bumps PG minor update server and spock versions.#20
maqeel75 merged 2 commits into
mainfrom
pg-may-updates

Conversation

@maqeel75
Copy link
Copy Markdown
Member

@maqeel75 maqeel75 commented May 12, 2026

PG minor plus spock version updates

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

Build configuration and package list manifests updated: Postgres patch versions bumped for majors 16/17/18, Spock upgraded to 5.0.8, epoch changed in the build script, and AMD64/ARM64 minimal/standard package lists populated or updated to match.

Changes

Version Bump Across Build Configuration and Package Manifests

Layer / File(s) Summary
Build image configuration with version updates
scripts/build_pgedge_images.py
The all_images matrix is updated: Postgres patch versions bumped (16.14, 17.10, 18.4), Spock upgraded to 5.0.8, and epoch changed from 2 to 1 in the make_all_flavor_images calls.
AMD64 package list manifests
packagelists/amd64/pg16.14-spock5.0.8-minimal.txt, packagelists/amd64/pg16.14-spock5.0.8-standard.txt, packagelists/amd64/pg17.10-spock5.0.8-minimal.txt, packagelists/amd64/pg17.10-spock5.0.8-standard.txt, packagelists/amd64/pg18.4-spock5.0.8-minimal.txt, packagelists/amd64/pg18.4-spock5.0.8-standard.txt
AMD64 minimal lists are populated with four pgedge-* entries each (Postgres, Spock, Snowflake, Lolor). AMD64 standard lists update Postgres and Spock package entries to the new versions.
ARM64 package list manifests
packagelists/arm64/pg16.14-spock5.0.8-minimal.txt, packagelists/arm64/pg16.14-spock5.0.8-standard.txt, packagelists/arm64/pg17.10-spock5.0.8-minimal.txt, packagelists/arm64/pg17.10-spock5.0.8-standard.txt, packagelists/arm64/pg18.4-spock5.0.8-minimal.txt, packagelists/arm64/pg18.4-spock5.0.8-standard.txt
ARM64 minimal lists are populated with four pgedge-* entries each (Postgres, Spock, Snowflake, Lolor). ARM64 standard lists update Postgres and Spock package entries to the new versions.

Poem

🐰 I hop through manifests, versions in tow,
Patches aligned where the build flags glow.
Spock climbs to five point oh eight tonight,
Epoch set tidy, package lists right.
AMD and ARM both dance in the row.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title directly describes the main changes: bumping PostgreSQL minor versions (16.13→16.14, 17.9→17.10, 18.3→18.4) and Spock versions (5.0.6→5.0.8) across the codebase.
Description check ✅ Passed The pull request description is related to the changeset, referencing PG minor and Spock version updates which align with the package list and build script modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pg-may-updates

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented May 12, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/build_pgedge_images.py`:
- Line 169: The global matrix currently hardcodes
package_release_channel="staging" (seen where package_release_channel is set in
scripts/build_pgedge_images.py), causing every build to publish to staging;
change this to read from configuration or an environment variable with a safe
default (e.g., os.getenv("PACKAGE_RELEASE_CHANNEL", "staging") or a Config class
default) and replace the three hardcoded occurrences (the
package_release_channel assignments at the three locations) to use that
configurable value so callers can override the channel without editing code.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0fb2f39-ffa0-4a65-bdec-260095abd6af

📥 Commits

Reviewing files that changed from the base of the PR and between d19cdb3 and 754096c.

📒 Files selected for processing (19)
  • packagelists/amd64/pg16.13-spock5.0.7-minimal.txt
  • packagelists/amd64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/amd64/pg16.14-spock5.0.8-standard.txt
  • packagelists/amd64/pg17.10-spock5.0.8-minimal.txt
  • packagelists/amd64/pg17.10-spock5.0.8-standard.txt
  • packagelists/amd64/pg17.9-spock5.0.7-minimal.txt
  • packagelists/amd64/pg18.3-spock5.0.7-minimal.txt
  • packagelists/amd64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/amd64/pg18.4-spock5.0.8-standard.txt
  • packagelists/arm64/pg16.13-spock5.0.7-minimal.txt
  • packagelists/arm64/pg16.14-spock5.0.8-minimal.txt
  • packagelists/arm64/pg16.14-spock5.0.8-standard.txt
  • packagelists/arm64/pg17.10-spock5.0.8-minimal.txt
  • packagelists/arm64/pg17.10-spock5.0.8-standard.txt
  • packagelists/arm64/pg17.9-spock5.0.7-minimal.txt
  • packagelists/arm64/pg18.3-spock5.0.7-minimal.txt
  • packagelists/arm64/pg18.4-spock5.0.8-minimal.txt
  • packagelists/arm64/pg18.4-spock5.0.8-standard.txt
  • scripts/build_pgedge_images.py
💤 Files with no reviewable changes (6)
  • packagelists/amd64/pg16.13-spock5.0.7-minimal.txt
  • packagelists/arm64/pg17.9-spock5.0.7-minimal.txt
  • packagelists/amd64/pg18.3-spock5.0.7-minimal.txt
  • packagelists/arm64/pg18.3-spock5.0.7-minimal.txt
  • packagelists/arm64/pg16.13-spock5.0.7-minimal.txt
  • packagelists/amd64/pg17.9-spock5.0.7-minimal.txt

Comment thread scripts/build_pgedge_images.py Outdated
@maqeel75 maqeel75 requested a review from mmols May 12, 2026 14:20
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@scripts/build_pgedge_images.py`:
- Line 166: The PR changes immutable image tags by decrementing epoch from 2 to
1 (the `epoch` value set to 1 in the image definitions), which can break version
precedence and automation; update the code by either restoring the previous
epoch or adding an explicit justification: add a short inline comment next to
each `epoch` assignment (the `epoch` variable in the image tag definitions)
explaining why you lowered it (e.g., policy change, rebuild semantics, or
coordinated versioning plan), and also add a one-line entry to the repository
changelog or the script header documenting the global rationale for the epoch
change so consumers and automation understand the new ordering. Ensure the
comment references the same `epoch` assignments so reviewers can verify
consistency across all image sets.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b0fd08d-5834-4310-b2b7-4ebb619f787c

📥 Commits

Reviewing files that changed from the base of the PR and between 8b14cf6 and 16c102a.

📒 Files selected for processing (1)
  • scripts/build_pgedge_images.py

Comment thread scripts/build_pgedge_images.py
@maqeel75 maqeel75 requested a review from moizpgedge May 18, 2026 11:22
@maqeel75 maqeel75 merged commit a358b50 into main May 18, 2026
32 of 33 checks passed
@maqeel75 maqeel75 deleted the pg-may-updates branch May 18, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants