Conversation
Nothing in CI built the standalone compiler added in EdgeTX#7275, so a change under radio/src/thirdparty/Lua could break it unnoticed. Build it on all three runner OSes, check the bytecode header matches the radio's 32-bit layout, load the result back, and check a syntax error is rejected. luac.c only pulled in alloca() for GCC/clang; include <malloc.h> for MSVC so the Windows build works with the default generator. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
UCRT's malloc.h only maps alloca to _alloca when non-standard names are enabled, which /std:c11 and later turn off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The macro ended in ';' and was used as 'CommonTable;', leaving an empty member declaration in struct Table and struct ROTable. GCC and clang accept that (-Wpedantic warns), but MSVC rejects it, which broke every file that includes lobject.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Superseded by EdgeTX#7848 (merged). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing in CI builds the standalone compiler added in EdgeTX#7275, so a change under
radio/src/thirdparty/Luacould break it without anyone noticing. This matters now thatedgetx-luacis being wrapped in a GitHub Action for script authors (ELRS, yaapu, …), because the action builds it from EdgeTX sources.Changes
.github/workflows/luac.yml, which runs only whenradio/src/thirdparty/Lua/**or the workflow itself changes. Onubuntu-latest,macos-latestandwindows-latestit:edgetx-luacwith CMake1B4C7561 53 00 19930D0A1A0A 04 04 04 04 04)lundumpluac.c: declarealloca()for MSVC as well. Before this,<alloca.h>was only included for GCC/clang, so the default Visual Studio generator on Windows couldn't build it.Testing
🤖 Generated with Claude Code