[4.x] Fix Checks#1709
Open
JonPurvis wants to merge 1 commit into
Open
Conversation
pest-plugin-browser ^4.3.1 requires pestphp/pest ^4.4.5 on the root package. Without an explicit version, Composer infers dev-<branch> on PR branches, which fails composer update before tests run.
Contributor
Author
|
Hey @nunomaduro 👋 Does this change make sense to you? I noticed checks failing on my earlier PR and I believe this is the fix needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
After pest-plugin-browser was raised to
^4.3.1(e766825f), PRs from branches not named4.xfail at composer update because the root package is inferred asdev-<branch>, which does not satisfy pest^4.4.5. Setting the root version unblocks CI for all PRs targeting4.x.