Repository navigation
Inheritance fixes - #178
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Ran into type errors with single table inheritance:
Changes
Added generic parameter and fixed parent class.
After extending the correct parent class, QuickBuilder failed, because the base classes were loaded together, but the parent class was not yet available, as it was loaded along with the other user classes.
Implementation Details
Also updated QuickBuilder and did some code maintenance in the inheritance builder classes.
Test strategy
For new methods. Builder output is tested in reference files.
Notes
I think QuickBuilder has a lot of carry-over from Propel1. I removed the public method
QuickBuilder::getClasses(), which built code and glued it together, because I don't see how this could still be used in a meaningful way.