Skip to content

Inheritance fixes - #178

Merged
mringler merged 5 commits into
perplorm:mainfrom
mringler:inheritance-fixes
Nov 11, 2026
Merged

mringler merged 5 commits into
perplorm:mainfrom
mringler:inheritance-fixes

Conversation

@mringler

@mringler mringler commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Issue

Ran into type errors with single table inheritance:

  • Base classes are missing the generic query parameter
  • When extending another extending class, it inherits from the base class, not the user class

Changes

Added generic parameter and fixed parent class.
After extending the correct parent class, QuickBuilder failed, because the base classes were loaded together, but the parent class was not yet available, as it was loaded along with the other user classes.

Implementation Details

Also updated QuickBuilder and did some code maintenance in the inheritance builder classes.

Test strategy

For new methods. Builder output is tested in reference files.

Notes

I think QuickBuilder has a lot of carry-over from Propel1. I removed the public method QuickBuilder::getClasses(), which built code and glued it together, because I don't see how this could still be used in a meaningful way.

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

@mringler mringler added the typing Narrows used data types or adds type checks label Nov 11, 2026
@mringler
mringler merged commit 143db5b into perplorm:main Nov 11, 2026
42 checks passed
@mringler
mringler deleted the inheritance-fixes branch November 11, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typing Narrows used data types or adds type checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant