Repository navigation
Resolve schema attribute 'collection-class' with leading backslash - #174
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mringler
force-pushed
the
fix_collection_class_namespace
branch
from
October 28, 2026 16:37
b5c7eb8 to
9eb6327
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
collection-classattribute on Table (and Database) is used in docstrings, which require a fully qualified name starting with a backslash, but user input might not match that.Changes
When retrieving the name, make sure it matches the format.
Implementation Details
Uses the existing method
ScopedMappingModel::makeClassNameAbsolute().Test strategy
Unit tests
Notes
Also fixed some new stan errors.
I've added a long missing method ModelCriteria::findRows() for typed access using SimpleArrayFormatter (used with
select()) to get enough lines so Codecov won't complain about untested lines ( containingassert()statements).