Skip to content

Resolve schema attribute 'collection-class' with leading backslash - #174

Merged
mringler merged 4 commits into
perplorm:mainfrom
mringler:fix_collection_class_namespace
Oct 29, 2026
Merged

mringler merged 4 commits into
perplorm:mainfrom
mringler:fix_collection_class_namespace

Conversation

@mringler

@mringler mringler commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Issue

The collection-class attribute on Table (and Database) is used in docstrings, which require a fully qualified name starting with a backslash, but user input might not match that.

Changes

When retrieving the name, make sure it matches the format.

Implementation Details

Uses the existing method ScopedMappingModel::makeClassNameAbsolute().

Test strategy

Unit tests

Notes

Also fixed some new stan errors.
I've added a long missing method ModelCriteria::findRows() for typed access using SimpleArrayFormatter (used with select()) to get enough lines so Codecov won't complain about untested lines ( containing assert() statements).

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Propel/Generator/Reverse/MysqlSchemaParser.php 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mringler
mringler force-pushed the fix_collection_class_namespace branch from b5c7eb8 to 9eb6327 Compare October 28, 2026 16:37
@mringler
mringler merged commit abc3c66 into perplorm:main Oct 29, 2026
42 checks passed
@mringler
mringler deleted the fix_collection_class_namespace branch October 29, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant