fix: replace procps-ng with Toybox process probes - #43
Merged
Merged
Conversation
longlho
marked this pull request as ready for review
September 20, 2026 01:46
longlho
pushed a commit
that referenced
this pull request
Sep 20, 2026
🤖 I have created a release *beep* *boop* --- ## 3.3.1 (2026-09-20) ## What's Changed * fix: replace procps-ng with Toybox process probes by @longlho in #43 **Full Changelog**: v3.3.0...v3.3.1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel's native test launcher uses
pgrep -a -g PGIDto keep its cleanup helper alive while the test process group exists. The isolated test-tool bundle currently builds procps-ng solely for that probe, adding a source download and a compatibility patch alongside Toybox.Use the already-declared static Toybox
pgrep. A private shell adapter drops-aonly for Bazel's exact three-argument probe: the launcher checks for nonempty output, so printing PIDs preserves its behavior. Other invocations retain Toybox's native argument handling. The pinned Toybox version also incorrectly sharesps -g's Unix-group selector withpgrep -g; extend the existing Toybox patch to select process groups for pgrep while preserving ps behavior. Remove the procps-ng repository and patch.Generate the shell functions in the tool bundle so the launcher and utility tests use the same implementation. Exercise groups with a live leader, a surviving member after the leader exits, and no remaining members, with an empty PATH. Static ELF checks still cover every bundled executable.