fix: reject unmatched entry globs - #110
Merged
Merged
Conversation
longlho
marked this pull request as ready for review
July 31, 2026 13:24
longlho
enabled auto-merge (squash)
July 31, 2026 13:24
longlho
pushed a commit
that referenced
this pull request
Jul 31, 2026
🤖 I have created a release *beep* *boop* --- ## [0.10.1](codescythe_cli_v0.10.0...codescythe_cli_v0.10.1) (2026-07-31) ### Bug Fixes * reject unmatched entry globs ([#110](#110)) ([c602395](c602395)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Entry globs were combined before matching, so one valid pattern could hide another pattern that matched nothing. This could silently leave expected entry points out of analysis.
Test plan
bazel test //crates/codescythe:codescythe_test //crates/codescythe_cli:codescythe_cli_e2e_test --test_output=errorscargo fmt --allgit diff --checkPR_TITLE='fix: reject unmatched entry globs' lefthook run pre-commit --all-files