Reject signed non-authorizing receipt statuses#2
Open
manuelsampedro1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusis not one of the v1 authorization lifecycle statesReceiptStatus = "valid" | "revoked"at the schema boundaryrevokedclassified as expired/revoked, but fail closed for unknown or non-canonical statusesDENIED, trailing-whitespacevalid, and non-string status valuesWhy
The local verifier previously treated every signed, unexpired status except lowercase
revokedas authorization-valid. That means any signed receipt carrying a non-authorizing or legacy status such asDENIED,PENDING, orEXPIREDcould be accepted by downstream consumers that rely onpp verify/verifyReceiptexit code as the authorization decision.The latest patch makes the schema boundary explicit before key resolution and before Ed25519 signature verification. Unknown or non-canonical statuses now fail as
MALFORMED_RECEIPT, so downstream verifier consumers never get a successful verification result for a signed non-authorizing status.Related to permission-protocol/deploy-gate#49 and the permission-protocol/deploy-gate#36 bypass challenge because this is a flaw in the signing/verification acceptance flow rather than a raw signature forgery.
Validation
node node_modules/vitest/vitest.mjs runnode node_modules/typescript/bin/tsc -p tsconfig.jsongit diff --check origin/main...HEADResult: 8 tests passed, TypeScript compile passed, diff whitespace check passed.