Retain SE-0348 result builder methods (buildPartialBlock)#1140
Open
JOyo246 wants to merge 1 commit into
Open
Conversation
…uildPartialBlock(accumulated:next:) Swift 5.7 (SE-0348) added two new result builder protocol methods as an incremental-building alternative to buildBlock. Periphery was not retaining them, causing false positives for any result builder that implements the SE-0348 API surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Swift 5.7 introduced SE-0348 which added two new optional static methods to the result builder protocol:
buildPartialBlock(first:)buildPartialBlock(accumulated:next:)These are a more expressive alternative to
buildBlockfor incrementally combining components. Because they weren't listed inResultBuilderRetainer, Periphery reported them as unused — a false positive for any result builder that adopts the SE-0348 API.Fix
Added both method names to the
resultBuilderMethodsset inResultBuilderRetainer.swift, added implementations to the retention fixture, and added assertions to the existingtestRetainsResultBuilderMethodstest.Testing
FixtureClass130intestRetainsResultBuilderMethods.swiftwith bothbuildPartialBlockvariantsassertReferencedassertions inRetentionTest.testRetainsResultBuilderMethods()