Skip to content

🧪 Add lfsr_tap test coverage#15

Merged
perim merged 1 commit into
mainfrom
test-lfsr-tap-7985626611225669783
Jul 19, 2026
Merged

🧪 Add lfsr_tap test coverage#15
perim merged 1 commit into
mainfrom
test-lfsr-tap-7985626611225669783

Conversation

@perim

@perim perim commented Jul 19, 2026

Copy link
Copy Markdown
Owner

🎯 What: The lfsr_tap function in dmath.cpp previously lacked any test coverage. It's a pure switch statement returning magic numbers for valid configurations.
📊 Coverage: A new test block in tests/test_dmath.cpp validates the exact output for boundary constraints (sizes 2 and 32). It also iterates over all valid input sizes (2 through 32) and checks that a non-zero tap is returned.
Result: Test coverage for lfsr_tap is now significantly improved by exercising all supported configurations and explicitly verifying edge cases, protecting against regressions if the magic number generation is refactored.


PR created automatically by Jules for task 7985626611225669783 started by @perim

Co-authored-by: perim <436583+perim@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@perim
perim merged commit 10931b9 into main Jul 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant