🧪 Add lfsr_tap test coverage#15
Conversation
Co-authored-by: perim <436583+perim@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The
lfsr_tapfunction indmath.cpppreviously lacked any test coverage. It's a pure switch statement returning magic numbers for valid configurations.📊 Coverage: A new test block in
tests/test_dmath.cppvalidates the exact output for boundary constraints (sizes 2 and 32). It also iterates over all valid input sizes (2 through 32) and checks that a non-zero tap is returned.✨ Result: Test coverage for
lfsr_tapis now significantly improved by exercising all supported configurations and explicitly verifying edge cases, protecting against regressions if the magic number generation is refactored.PR created automatically by Jules for task 7985626611225669783 started by @perim