⚡ Optimize const_roll_table init by replacing queue with vector#12
Conversation
Using std::vector with reserve avoids multiple memory block allocations that happen with std::queue (std::deque). LIFO processing via push_back/pop_back works perfectly fine for Vose's Alias Method setup. Co-authored-by: perim <436583+perim@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Using std::vector with reserve avoids multiple memory block allocations that happen with std::queue (std::deque). LIFO processing via push_back/pop_back works perfectly fine for Vose's Alias Method setup. Co-authored-by: perim <436583+perim@users.noreply.github.com>
💡 What: Replaced
std::queue<int>withstd::vector<int>for thesmallandlargecollections inconst_roll_table::init. Used.reserve(size)to preallocate memory, and updated operations topush_back,back, andpop_back.🎯 Why:
std::queuedefaults tostd::deque, which allocates multiple blocks of memory. Astd::vectoris a contiguous block of memory and avoids these allocations entirely when properly pre-allocated withreserve(). Vose's Alias Method setup algorithm does not require FIFO ordering, so processing as a LIFO stack is perfectly safe and algorithmically equivalent.📊 Measured Improvement:
Measured using
cpu_gettime():PR created automatically by Jules for task 11820680638652560055 started by @perim