PS4M. Add workflow to build mongot image on PRs - #24
Conversation
There was a problem hiding this comment.
Pull request overview
Adds CI automation to build a PR-scoped “dev” Docker image for mongot from this repository’s source, publish it as a GitHub Actions artifact, optionally push it to Docker Hub when credentials are available, and clean up the per-PR Docker Hub tag when the PR closes.
Changes:
- Add a dev Docker image definition (Dockerfile + entrypoint) for running
mongotfrom a bundled build artifact. - Add a PR workflow that builds
//deploy:mongot-community, assembles a Docker build context, builds the image, and uploads it as an artifact (optionally pushes to Docker Hub). - Add a cleanup workflow that deletes the
pr-<number>Docker Hub tag when the PR is closed.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
percona-packaging/docker/mongot-entry.sh |
New container entrypoint to map CLI args to mongot execution. |
percona-packaging/docker/Dockerfile |
New dev image Dockerfile that installs runtime deps and bundles the Bazel-produced mongot tarball. |
.github/workflows/dev-docker-image.yml |
New workflow to build the mongot bundle and Docker image on PRs and upload it as an artifact (optional push). |
.github/workflows/dev-docker-image-cleanup.yml |
New workflow to delete the PR-tagged Docker Hub image when the PR closes. |
Suppressed comments (1)
.github/workflows/dev-docker-image.yml:111
- The conditional only checks for
DOCKERHUB_TOKEN, but this step assumesDOCKERHUB_USERNAMEwas configured (and the login step ran). Guard on both to avoid attempting a push when credentials are incomplete.
- name: Push image to perconalab
if: env.DOCKERHUB_TOKEN != ''
run: |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4bef9c8 to
0e6eee7
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
.github/workflows/dev-docker-image-cleanup.yml:23
- This workflow doesn’t declare
permissions, so it will inherit the repo’s default GITHUB_TOKEN permissions (often broader than needed). Since the job only talks to Docker Hub, explicitly set minimal permissions (e.g. none).
delete-tag:
runs-on: ubuntu-latest
timeout-minutes: 10
percona-packaging/docker/mongot-entry.sh:10
- Comment typo: “execed” should be spelled “exec'ed” (or similar).
# config supplied via CMD. Any other command (e.g. `sh`) is execed as-is
27e805a to
3ba7058
Compare
3ba7058 to
0a7200b
Compare
No description provided.