Skip to content

PS4M. Add workflow to build mongot image on PRs - #24

Open
sandraromanchenko wants to merge 1 commit into
mainfrom
docker_build
Open

PS4M. Add workflow to build mongot image on PRs#24
sandraromanchenko wants to merge 1 commit into
mainfrom
docker_build

Conversation

@sandraromanchenko

Copy link
Copy Markdown

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI automation to build a PR-scoped “dev” Docker image for mongot from this repository’s source, publish it as a GitHub Actions artifact, optionally push it to Docker Hub when credentials are available, and clean up the per-PR Docker Hub tag when the PR closes.

Changes:

  • Add a dev Docker image definition (Dockerfile + entrypoint) for running mongot from a bundled build artifact.
  • Add a PR workflow that builds //deploy:mongot-community, assembles a Docker build context, builds the image, and uploads it as an artifact (optionally pushes to Docker Hub).
  • Add a cleanup workflow that deletes the pr-<number> Docker Hub tag when the PR is closed.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
percona-packaging/docker/mongot-entry.sh New container entrypoint to map CLI args to mongot execution.
percona-packaging/docker/Dockerfile New dev image Dockerfile that installs runtime deps and bundles the Bazel-produced mongot tarball.
.github/workflows/dev-docker-image.yml New workflow to build the mongot bundle and Docker image on PRs and upload it as an artifact (optional push).
.github/workflows/dev-docker-image-cleanup.yml New workflow to delete the PR-tagged Docker Hub image when the PR closes.
Suppressed comments (1)

.github/workflows/dev-docker-image.yml:111

  • The conditional only checks for DOCKERHUB_TOKEN, but this step assumes DOCKERHUB_USERNAME was configured (and the login step ran). Guard on both to avoid attempting a push when credentials are incomplete.
      - name: Push image to perconalab
        if: env.DOCKERHUB_TOKEN != ''
        run: |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread percona-packaging/docker/mongot-entry.sh Outdated
Comment thread .github/workflows/dev-docker-image.yml Outdated
Comment thread .github/workflows/dev-docker-image.yml Outdated
Comment thread .github/workflows/dev-docker-image-cleanup.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Suppressed comments (2)

.github/workflows/dev-docker-image-cleanup.yml:23

  • This workflow doesn’t declare permissions, so it will inherit the repo’s default GITHUB_TOKEN permissions (often broader than needed). Since the job only talks to Docker Hub, explicitly set minimal permissions (e.g. none).
  delete-tag:
    runs-on: ubuntu-latest
    timeout-minutes: 10

percona-packaging/docker/mongot-entry.sh:10

  • Comment typo: “execed” should be spelled “exec'ed” (or similar).
# config supplied via CMD. Any other command (e.g. `sh`) is execed as-is

@sandraromanchenko
sandraromanchenko force-pushed the docker_build branch 2 times, most recently from 27e805a to 3ba7058 Compare August 7, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants