Skip to content

fix(signing): show minted assets and simulation failures in the group review [PERA-4729] - #1095

Merged
yasin-ce merged 1 commit into
mainfrom
yasince/fix/PERA-4729
Jul 31, 2026
Merged

fix(signing): show minted assets and simulation failures in the group review [PERA-4729]#1095
yasin-ce merged 1 commit into
mainfrom
yasince/fix/PERA-4729

Conversation

@yasin-ce

Copy link
Copy Markdown
Collaborator

Description

  • Surfaces assets minted by the user's own accounts in the group review. A mint moves no existing asset, so it produced no balance delta and a mint group previously showed no impact at all.
  • Surfaces simulation failures in the same summary rather than leaving the review silent about them.

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

createdAssets rows are keyed by group position, not asset id: an acfg mint carries assetId: 0 until the group confirms, and 0 is ALGO's id in this map — so a mint cannot be netted into deltas without colliding with ALGO. That is why it is a separate list rather than another delta.

Not device-verified. The multi-mint case is the one worth eyeballing on a device before this leaves draft; the unit tests cover the computation, not the rendered review.

@yasin-ce
yasin-ce force-pushed the yasince/fix/PERA-4729 branch from f8c66e6 to 26b68e4 Compare July 30, 2026 13:21
@filipetamota

Copy link
Copy Markdown
Collaborator

@yasin-ce QA and code review done ✅

@yasin-ce
yasin-ce marked this pull request as ready for review July 31, 2026 09:14
@yasin-ce
yasin-ce requested a review from a team as a code owner July 31, 2026 09:14
@yasin-ce
yasin-ce force-pushed the yasince/fix/PERA-4729 branch from 26b68e4 to 2ff0031 Compare July 31, 2026 09:22
@yasin-ce
yasin-ce merged commit 4ea352a into main Jul 31, 2026
15 checks passed
@yasin-ce
yasin-ce deleted the yasince/fix/PERA-4729 branch July 31, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants