fix(signing): show minted assets and simulation failures in the group review [PERA-4729] - #1095
Merged
Conversation
yasin-ce
force-pushed
the
yasince/fix/PERA-4729
branch
from
July 30, 2026 13:21
f8c66e6 to
26b68e4
Compare
Collaborator
|
@yasin-ce QA and code review done ✅ |
yasin-ce
marked this pull request as ready for review
July 31, 2026 09:14
wjbeau
approved these changes
Jul 31, 2026
… review [PERA-4729]
yasin-ce
force-pushed
the
yasince/fix/PERA-4729
branch
from
July 31, 2026 09:22
26b68e4 to
2ff0031
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Checklist
Additional Notes
createdAssetsrows are keyed by group position, not asset id: anacfgmint carriesassetId: 0until the group confirms, and 0 is ALGO's id in this map — so a mint cannot be netted intodeltaswithout colliding with ALGO. That is why it is a separate list rather than another delta.Not device-verified. The multi-mint case is the one worth eyeballing on a device before this leaves draft; the unit tests cover the computation, not the rendered review.