Skip to content

fix(settings): use PWText on WalletConnect settings screens [PERA-4684] - #1080

Draft
yasin-ce wants to merge 2 commits into
mainfrom
yasince/fix/PERA-4684
Draft

fix(settings): use PWText on WalletConnect settings screens [PERA-4684]#1080
yasin-ce wants to merge 2 commits into
mainfrom
yasince/fix/PERA-4684

Conversation

@yasin-ce

Copy link
Copy Markdown
Collaborator

Description

  • The WalletConnect settings screens rendered unwrapped Text from @rneui/themed, bypassing the PW wrapper and its typography variants. Swapped to PWText.
  • The peer fallback label was a hardcoded 'Unknown'; it is now a t() key (walletconnect.settings.unknown_peer).

Related Issues

Checklist

  • Have you tested your changes locally?
  • Have you reviewed the code for any potential issues?
  • Have you documented any necessary changes in the project's documentation?
  • Have you added any necessary tests for your changes?
  • Have you updated any relevant dependencies?

Additional Notes

  • No new test: a wrapper swap plus an i18n key, and the repo's testing rules exclude style assertions.
  • The chainId === 4160 || chainId === 416_001 literals in ConnectedNetworks are pre-existing and deliberately left alone to keep this diff to the two rules it's enforcing.

@filipetamota

Copy link
Copy Markdown
Collaborator

@yasin-ce The TextPWText swap is correct and does cap the body text — on main these strings scaled unbounded (tops of letters only), and now they cap at ~1.5×. But at max Dynamic Type the screen still breaks, in places this PR didn't touch (screenshots attached):

  1. WCV1 badge clips (only tops visible). That's PWBadge, which has a fixed height: theme.spacing.xl — a fixed-height pill can't grow for large font. It's a shared core component, so badges clip app-wide at large font, not just here.
  2. The "Connected" / "MAINNET" status pills clip the same way (fixed-height pills).
  3. The version row overflows horizontally ("…using Wa… V1" cut off on the right). versionContainer is flexDirection: 'row' with the badge + text and no flexShrink/wrap on the text.

So this correctly does the scoped Text swap, but the screen still doesn't render cleanly at high font. Suggest either expanding this PR to fix the version row (flexShrink: 1 on the text, or stack the badge + text at large sizes) and the pill heights, or merging as a partial improvement with a follow-up for PWBadge's fixed height (app-wide) + the status pills + the row overflow — and not closing this as "high-font fixed" on its own.

Photo 30-07-2026, 10 12 22 Photo 30-07-2026, 10 12 28

@yasin-ce
yasin-ce force-pushed the yasince/fix/PERA-4684 branch 2 times, most recently from baa8770 to 813bff5 Compare July 30, 2026 13:21
@yasin-ce
yasin-ce force-pushed the yasince/fix/PERA-4684 branch from 813bff5 to 621baeb Compare July 31, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants