Declare requests as an install dependency - #3
Open
szx19970521 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2.
The published package imports
requestsat module import time, but the package metadata only installshabaneroandbibtexparser. With currenthabanero,requestsis no longer pulled transitively, so a clean install fails before users can instantiateORCID2Markdown.Reproduced with:
Before this change:
This PR adds the packaging files that are already present in the PyPI sdist, declares
requestsininstall_requires, and also updates/adds requirements files for source users.Verified from this branch with a clean venv:
Result: