Michael Munsey HW submission#8
Open
munseym wants to merge 1 commit into
Open
Conversation
bwreid
reviewed
Aug 11, 2019
bwreid
left a comment
bwreid
left a comment
Collaborator
There was a problem hiding this comment.
This is really excellent work, Michael. I tried to give you a few helpful comments for the next time, but let me know if you're looking for any additional feedback.
|
|
||
| const schema = mongoose.Schema({ | ||
| username: String, | ||
| password: String |
Collaborator
There was a problem hiding this comment.
You'll also want to include a boolean here of admin.
| }finally{ | ||
| next() | ||
| } | ||
| }) |
Collaborator
There was a problem hiding this comment.
This is great! Just be careful where to put this. It's likely that not all routes will need auth. For example, your signup and login routes below will still attempt to run this code, even though it's not needed.
Additionally, this could be put in app.js.
| const error = new Error(`Unauthorized.`) | ||
| error.status = 401 | ||
| next(error) | ||
| } |
Collaborator
There was a problem hiding this comment.
This small bit of code could then like go to a route-level middleware function like isLoggedIn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.