Skip to content

Use the preprocessor to only import Semigroup when we need to #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HuwCampbell merged 1 commit into from
Jun 27, 2026
Merged

Use the preprocessor to only import Semigroup when we need to #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion optparse-applicative.cabal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,5 +156,5 @@ test-suite tests
, optparse-applicative
, QuickCheck >= 2.8 && < 2.17

if !impl(ghc >= 8)
if impl(ghc < 8)
build-depends: semigroups
3 changes: 3 additions & 0 deletions src/Options/Applicative/Builder/Internal.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{-# LANGUAGE CPP #-}
module Options.Applicative.Builder.Internal (
-- * Internals
Mod(..),
Expand Down Expand Up @@ -27,7 +28,9 @@ module Options.Applicative.Builder.Internal (
import Control.Applicative
import Control.Monad (mplus)
import Data.List.NonEmpty (NonEmpty)
#if __GLASGOW_HASKELL__ < 804
import Data.Semigroup hiding (Option)
#endif
import Prelude

import Options.Applicative.Common
Expand Down
2 changes: 2 additions & 0 deletions src/Options/Applicative/Types.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ import Control.Monad.Trans.Class (lift)
import Control.Monad.Trans.Reader (ReaderT, ask)
import qualified Control.Monad.Fail as Fail
import Data.List.NonEmpty (NonEmpty)
#if __GLASGOW_HASKELL__ < 804
import Data.Semigroup hiding (Option)
#endif
import Prelude

import System.Exit (ExitCode(..))
Expand Down
Loading