Skip to content

Remove clientTracking from WebSocket.Server - #13

Open
bri3d wants to merge 1 commit into
pbomb:masterfrom
bri3d:patch-1
Open

Remove clientTracking from WebSocket.Server#13
bri3d wants to merge 1 commit into
pbomb:masterfrom
bri3d:patch-1

Conversation

@bri3d

@bri3d bri3d commented May 6, 2020

Copy link
Copy Markdown

What:

Previously, the clientTracking feature in WebSocket.Server was enabled. Unfortunately, in socket.ts, we remove all listeners from the WebSocket itself. This causes the close behavior removing the Socket from the clients list in WebSocket.Server not to function. Because the terminate functionality provided by clientTracking is never used with this project, the easiest solution is to remove it.

Why:

Prevent leakage of every Socket.

How:

Disabling clientTracking functionality of WebSocket.Server to eliminate dependency on existing close handlers on the WebSocket object.

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged

Previously, the `clientTracking` feature in WebSocket.Server was enabled. Unfortunately, in `socket.ts`, we remove all listeners from the `WebSocket` itself. This causes the `close` behavior removing the Socket from the `clients` list in `WebSocket.Server` not to function. Because the `terminate` functionality provided by `clientTracking` is never used with this project, the easiest solution is to remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants