Remove clientTracking from WebSocket.Server - #13
Open
bri3d wants to merge 1 commit into
Open
Conversation
Previously, the `clientTracking` feature in WebSocket.Server was enabled. Unfortunately, in `socket.ts`, we remove all listeners from the `WebSocket` itself. This causes the `close` behavior removing the Socket from the `clients` list in `WebSocket.Server` not to function. Because the `terminate` functionality provided by `clientTracking` is never used with this project, the easiest solution is to remove it.
mateuscb
approved these changes
May 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Previously, the
clientTrackingfeature in WebSocket.Server was enabled. Unfortunately, insocket.ts, we remove all listeners from theWebSocketitself. This causes theclosebehavior removing the Socket from theclientslist inWebSocket.Servernot to function. Because theterminatefunctionality provided byclientTrackingis never used with this project, the easiest solution is to remove it.Why:
Prevent leakage of every Socket.
How:
Disabling
clientTrackingfunctionality ofWebSocket.Serverto eliminate dependency on existingclosehandlers on theWebSocketobject.Checklist: