Skip to content

fix: await CLI startup#16383

Closed
atimmer wants to merge 1 commit intopayloadcms:3.xfrom
atimmer:fix/payload-cli-top-level-await
Closed

fix: await CLI startup#16383
atimmer wants to merge 1 commit intopayloadcms:3.xfrom
atimmer:fix/payload-cli-top-level-await

Conversation

@atimmer
Copy link
Copy Markdown
Contributor

@atimmer atimmer commented Apr 24, 2026

What?

Ensures Payload writes a file before exiting the process.

Why?

Relevant explanation is in #16381

How?

Alternative to #16382. This adds top-level await. I didn't know if that is already allowed in the Payload codebase.

Fixes #16381

@atimmer atimmer changed the title fix(payload): await CLI startup fix: await CLI startup Apr 24, 2026
@atimmer
Copy link
Copy Markdown
Contributor Author

atimmer commented Apr 27, 2026

This doesn't work because Node.js will instead error with Warning: Detected unsettled top-level await at [filePath]. This is because top-level await doesn't force Node.js to stay alive.

@atimmer atimmer closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant