Skip to content

FIX: Featured badges selector not appearing in the profile when user has no badges#4

Merged
angusmcleod merged 2 commits into
paviliondev:masterfrom
Arkshine:fix/user-without-badges
Apr 18, 2025
Merged

FIX: Featured badges selector not appearing in the profile when user has no badges#4
angusmcleod merged 2 commits into
paviliondev:masterfrom
Arkshine:fix/user-without-badges

Conversation

@Arkshine
Copy link
Copy Markdown
Collaborator

Meta: https://meta.discourse.org/t/featured-badges-breaks-user-profile-page/361981

Followup #3.

This PR fixes an error that occurs when a user without badges visits their profile. The featured badges selector doesn't appear, and instead, it throws an error in the console.

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'split')
    at l.<anonymous> (user-featured-badges.js:12:1)

Before:
image

After:
chrome_ToPmxk9NCN

@Arkshine Arkshine force-pushed the fix/user-without-badges branch from 48c2d0f to 468317b Compare April 16, 2025 20:00
@Arkshine Arkshine force-pushed the fix/user-without-badges branch from 82f3ade to f8b306a Compare April 16, 2025 20:11
@angusmcleod
Copy link
Copy Markdown
Member

@Arkshine Thanks!

@angusmcleod angusmcleod merged commit 431a424 into paviliondev:master Apr 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants