fix: healthchecks for ecs, snowflake and trino#112
Merged
Conversation
Copilot started reviewing on behalf of
Yash Shrivastava (alephys26)
June 17, 2026 11:45
View session
Contributor
There was a problem hiding this comment.
⚠️ Not ready to approve
The Snowflake health check reads scanned column values using brittle string assertions that can mis-detect state/auto_resume and incorrectly fail (or misreport) readiness.
Pull request overview
Updates cluster health checks to simplify readiness logic for Trino and ECS, and to improve Snowflake readiness detection for suspended warehouses.
Changes:
- Trino: Health check now only validates the
/v1/infoendpoint (removes/v1/clustercapacity/worker checks). - ECS: Removes the max-task-count capacity gating from the ECS cluster health check.
- Snowflake: Adds
auto_resumeawareness soSUSPENDEDwarehouses can be considered healthy when auto-resume is enabled.
File summaries
| File | Description |
|---|---|
| internal/pkg/object/command/trino/trino.go | Removes Trino cluster-capacity/worker validation and keeps health check to /v1/info only. |
| internal/pkg/object/command/snowflake/snowflake.go | Extends Snowflake health check to handle SUSPENDED warehouses via auto_resume. |
| internal/pkg/object/command/ecs/ecs.go | Drops ECS cluster “at capacity” blocking logic from health checks. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prasadlohakpure
previously approved these changes
Jun 17, 2026
prasadlohakpure
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the health check logic for ECS, Snowflake, and Trino clusters, simplifying capacity checks and improving readiness detection. The main changes involve removing cluster capacity checks for ECS and Trino, and enhancing the Snowflake health check to handle suspended warehouses with auto-resume enabled.
Changes
Cluster Health Check Logic Updates:
internal/pkg/object/command/ecs/ecs.go)checkTrinoClusterCapacitymethod and its invocation, so Trino health checks now only verify the/v1/infoendpoint. (internal/pkg/object/command/trino/trino.go) [1] [2]Snowflake Health Check Improvements:
auto_resumecolumn index along withstate.SUSPENDEDstate to pass the health check ifauto_resumeis enabled, otherwise fail with a clear error message.internal/pkg/object/command/snowflake/snowflake.go) [1] [2]