Skip to content

feat(ColumnManagementModal): add support for extended columns#929

Open
raswonders wants to merge 4 commits intopatternfly:mainfrom
raswonders:feat/column-management-modal-generic-columns
Open

feat(ColumnManagementModal): add support for extended columns#929
raswonders wants to merge 4 commits intopatternfly:mainfrom
raswonders:feat/column-management-modal-generic-columns

Conversation

@raswonders
Copy link
Copy Markdown
Contributor

@raswonders raswonders commented May 7, 2026

Hey,

I've extended Modal so it supports subtype of ColumnManagementModalColumn

What this PR do?

ColumnManagementModal now fully works with custom shape columns which are subtype of ColumnManagementModalColumn

Why we need this?

  • Modal can be passed custom column objects, but it only returns column objects with rigid structure and strips any extra properties.
  • This is introducing complexity downstream, as we basically have to maintain two column structures, one for modal and one of our own

How we are fixing it?

  • ColumnManagementModal becomes generic over a column type that extends ColumnManagementModalColumn.
  • Modal passes back the same column objects we passed in, with only isShown updated, instead of rebuilding rows from ListManagerItem (which only recreated a subset of fields passed in).

API compatibilty concerns

  • Same prop names and runtime defaults
  • TypeScript: Un-parameterized usage still defaults to ColumnManagementModalColumn
  • applyColumns now receives full column objects. Previously, save dropped extra properties. That would be incompatible only if something relied on those extras being removed at save time for typical usage this is a bugfix and improves compatibility

@patternfly-build
Copy link
Copy Markdown

patternfly-build commented May 7, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants