feat: allow export with blocking page problems - #90
Merged
Conversation
Summary: - add an explicit, confirmed export override for current books - record accepted page problems in preflight reports and analytics Rationale: - organizers sometimes need a PDF despite known layout problems - stale generation and structural PDF failures remain blocking Tests: - SAKEKEEP_E2E_PORT=3100 bun run verify - local API: default 409, override 201 with four recorded problems AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-5.6-sol
Summary: - send the reviewed book fingerprint with export confirmation - reject accepted problems when the generated book changed - cover the stale-tab race at the server boundary Rationale: - an override must apply only to the problems the organizer reviewed Tests: - SAKEKEEP_E2E_PORT=3100 bun run verify - 43 test files and 361 unit tests passed - 22 end-to-end tests passed, 2 intentionally skipped AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Organizers can inspect a book and knowingly accept layout problems, but the export step has no escape hatch. This makes it impossible to produce a PDF when a problem is intentional or acceptable.
Solution
Add an explicit opt-in control in Print export that allows a current book to export despite blocking page problems. The export requires confirmation and records every accepted problem in the preflight report. The confirmation is bound to the exact generated book that was reviewed. Stale books and failed structural PDF checks remain blocked.
Validation
SAKEKEEP_E2E_PORT=3100 bun run verifyEvidence
Before: blocking problems disable export.
After: the explicit toggle accepts the problems and enables the confirmed export path.
Changes prepared by GPT-5.6-sol through T3 Code using the Codex harness.