Skip to content

fix: fallback artwork remains visible on colored layouts - #87

Merged
patriksimms merged 2 commits into
mainfrom
fix/fallback-art-visibility
Aug 24, 2026
Merged

fix: fallback artwork remains visible on colored layouts#87
patriksimms merged 2 commits into
mainfrom
fix/fallback-art-visibility

Conversation

@patriksimms

@patriksimms patriksimms commented Aug 24, 2026

Copy link
Copy Markdown
Owner

Problem

Fallback artwork borrowed the layout's colors. Parts of a motif disappeared when an empty photo slot crossed a background shape painted with the same color.

Solution

Use a muted blue, rose, and plum companion palette that fits the existing layouts without repeating their colors. A regression test checks every palette tone against all standard layouts in both orientations.

Validation

  • bun run lint
  • bun run typecheck
  • bun run test (357 tests)
  • bun run build with test Clerk configuration
  • docker compose config --quiet
  • bun run scripts/check-production-compose.ts
  • Compared all nine motifs over the yellow, terracotta, and green standard layout colors

Visual evidence

A matched synthetic comparison was generated directly from the production motif paths and palette logic. The prior version loses motif parts over matching colors; the new palette keeps all parts visible. Both images were inspected locally; the available GitHub browser session could not upload them because it was not signed in.


Implemented by Codex in T3 Code using openai/gpt-5.6-sol.

Summary:
- use a muted companion palette for empty photo-slot motifs
- verify every tone remains distinct from all standard layout colors

Rationale:
- borrowing layout colors hid motif parts over matching background shapes
- a dedicated palette preserves the style without requiring backdrop tracing

Tests:
- bun run lint
- bun run typecheck
- bun run test
- bun run build with test Clerk configuration
- docker compose config --quiet
- bun run scripts/check-production-compose.ts

AI-Assisted: true
AI-Agent: codex
AI-Model: openai/gpt-5.6-sol
Comment thread src/domain/filler-art.ts Outdated
@patriksimms
patriksimms marked this pull request as ready for review August 24, 2026 21:07
Summary:
- choose filler accents that remain distinct from colors painted by the layout
- add alternate muted accents for user-recolored layouts
- cover the reported custom-color collision with a regression test

Rationale:
- a fixed companion palette could repeat colors selected by an organizer
- schema-aware selection keeps motif parts visible after layout customization

Tests:
- bun run format:check
- bun run lint
- bun run typecheck
- bun run test (358 tests)

AI-Assisted: true
AI-Agent: codex
AI-Model: openai/gpt-5.6-sol
@patriksimms
patriksimms merged commit ecb84bc into main Aug 24, 2026
3 checks passed
@patriksimms
patriksimms deleted the fix/fallback-art-visibility branch August 24, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant