fix: fallback artwork remains visible on colored layouts - #87
Merged
Conversation
Summary: - use a muted companion palette for empty photo-slot motifs - verify every tone remains distinct from all standard layout colors Rationale: - borrowing layout colors hid motif parts over matching background shapes - a dedicated palette preserves the style without requiring backdrop tracing Tests: - bun run lint - bun run typecheck - bun run test - bun run build with test Clerk configuration - docker compose config --quiet - bun run scripts/check-production-compose.ts AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-5.6-sol
patriksimms
marked this pull request as ready for review
August 24, 2026 21:07
Summary: - choose filler accents that remain distinct from colors painted by the layout - add alternate muted accents for user-recolored layouts - cover the reported custom-color collision with a regression test Rationale: - a fixed companion palette could repeat colors selected by an organizer - schema-aware selection keeps motif parts visible after layout customization Tests: - bun run format:check - bun run lint - bun run typecheck - bun run test (358 tests) AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-5.6-sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fallback artwork borrowed the layout's colors. Parts of a motif disappeared when an empty photo slot crossed a background shape painted with the same color.
Solution
Use a muted blue, rose, and plum companion palette that fits the existing layouts without repeating their colors. A regression test checks every palette tone against all standard layouts in both orientations.
Validation
bun run lintbun run typecheckbun run test(357 tests)bun run buildwith test Clerk configurationdocker compose config --quietbun run scripts/check-production-compose.tsVisual evidence
A matched synthetic comparison was generated directly from the production motif paths and palette logic. The prior version loses motif parts over matching colors; the new palette keeps all parts visible. Both images were inspected locally; the available GitHub browser session could not upload them because it was not signed in.
Implemented by Codex in T3 Code using
openai/gpt-5.6-sol.