Conversation
The staging build android-dev.1231 uploaded its AAB but could not commit the Play edit: Changes cannot be sent for review automatically. Please set the query parameter changesNotSentForReview to true. so no internal release appeared. Google's edit commit demands one specific value for changesNotSentForReview and rejects the other, and which one it wants depends on Play Console review state that changes outside CI — a normal reviewed app rejects the flag, an app with review-gated changes pending requires it. Both directions have broken a staging upload now (false today, true back at android-dev.1026), so stop hand-flipping the literal: keep the normal-path value as the first attempt and retry once with the opposite value when the commit is refused. The failed edit is never committed, so its versionCode stays unused and the retry can re-upload the same AAB. A successful retry means the release is on the track but was NOT sent for review, so it emits a warning saying a human has to submit the pending changes in the Play Console. The failure warning and the run summary's Play outcome now both account for the retry. No unit test accompanies this: the change is entirely GitHub Actions workflow wiring, which the repo's JVM test suite cannot reach. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ht2BB4TWtkmC5EW5GsPXEM
Retry the Play publish with the opposite review flag
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## staging #812 +/- ##
==========================================
Coverage 42.40% 42.41%
Complexity 228 228
==========================================
Files 270 270
Lines 32450 32450
Branches 3735 3735
==========================================
+ Hits 13761 13764 +3
+ Misses 18413 18410 -3
Partials 276 276
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #811 to staging, and re-cuts the
0.150.0internal build that the previous promotion (#810) failed to publish.What's in this promotion
#811 — Retry the Play publish with the opposite review flag. The #810 promotion ran all-green but put nothing on the Play internal track: the AAB uploaded and then the edit commit was refused —
— and because the publish step is
continue-on-error, the run stayed green.android-dev.1231/0.150.0-dev.1231never reached testers.Google demands one specific value of
changesNotSentForReviewand rejects the other, depending on Play Console review state that changes outside CI (a normal reviewed app rejects the flag; an app with review-gated changes pending requires it). Both directions have broken a staging upload now. #811 stops hand-flipping the literal:falsestays the first attempt, and a retry step re-runs the upload withtruewhen the commit is refused.What to expect from this run
The Android job re-cuts the build with a fresh run number, so a new
android-dev.<run#>/ versionCode. Then either:Either way the run summary's
Play track: internal (publish: ...)line now reports the real outcome rather than only the first attempt's.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ht2BB4TWtkmC5EW5GsPXEM