Skip to content

Promote dev → staging (retry the Play publish with the opposite review flag) - #812

Merged
patrickrb merged 2 commits into
stagingfrom
dev
Sep 9, 2026
Merged

patrickrb merged 2 commits into
stagingfrom
dev

Conversation

@patrickrb

Copy link
Copy Markdown
Owner

Promotes #811 to staging, and re-cuts the 0.150.0 internal build that the previous promotion (#810) failed to publish.

What's in this promotion

#811 — Retry the Play publish with the opposite review flag. The #810 promotion ran all-green but put nothing on the Play internal track: the AAB uploaded and then the edit commit was refused —

##[error]Changes cannot be sent for review automatically. Please set the query
parameter changesNotSentForReview to true.

— and because the publish step is continue-on-error, the run stayed green. android-dev.1231 / 0.150.0-dev.1231 never reached testers.

Google demands one specific value of changesNotSentForReview and rejects the other, depending on Play Console review state that changes outside CI (a normal reviewed app rejects the flag; an app with review-gated changes pending requires it). Both directions have broken a staging upload now. #811 stops hand-flipping the literal: false stays the first attempt, and a retry step re-runs the upload with true when the commit is refused.

What to expect from this run

The Android job re-cuts the build with a fresh run number, so a new android-dev.<run#> / versionCode. Then either:

  • first attempt commits — Console review state has cleared, nothing else to do; or
  • the retry commits — the run emits a warning saying so. The release is on the internal track but was not auto-sent for review, so it needs a manual "send for review" in the Play Console before testers get it.

Either way the run summary's Play track: internal (publish: ...) line now reports the real outcome rather than only the first attempt's.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ht2BB4TWtkmC5EW5GsPXEM

patrickrb and others added 2 commits September 9, 2026 15:49
The staging build android-dev.1231 uploaded its AAB but could not commit
the Play edit:

  Changes cannot be sent for review automatically. Please set the query
  parameter changesNotSentForReview to true.

so no internal release appeared. Google's edit commit demands one
specific value for changesNotSentForReview and rejects the other, and
which one it wants depends on Play Console review state that changes
outside CI — a normal reviewed app rejects the flag, an app with
review-gated changes pending requires it. Both directions have broken a
staging upload now (false today, true back at android-dev.1026), so stop
hand-flipping the literal: keep the normal-path value as the first
attempt and retry once with the opposite value when the commit is
refused.

The failed edit is never committed, so its versionCode stays unused and
the retry can re-upload the same AAB.

A successful retry means the release is on the track but was NOT sent for
review, so it emits a warning saying a human has to submit the pending
changes in the Play Console. The failure warning and the run summary's
Play outcome now both account for the retry.

No unit test accompanies this: the change is entirely GitHub Actions
workflow wiring, which the repo's JVM test suite cannot reach.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ht2BB4TWtkmC5EW5GsPXEM
Retry the Play publish with the opposite review flag
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.41%. Comparing base (caadc95) to head (a34e3fe).
⚠️ Report is 17 commits behind head on staging.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             staging     #812   +/-   ##
==========================================
  Coverage      42.40%   42.41%           
  Complexity       228      228           
==========================================
  Files            270      270           
  Lines          32450    32450           
  Branches        3735     3735           
==========================================
+ Hits           13761    13764    +3     
+ Misses         18413    18410    -3     
  Partials         276      276           
Flag Coverage Δ
android 17.21% <ø> (ø)
desktop 63.95% <ø> (+0.06%) ⬆️
ios 97.71% <ø> (ø)
native 9.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@patrickrb
patrickrb merged commit 2b951dd into staging Sep 9, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant