Add support for nonempty variadic axes via + (Issue #378)#395
Open
pdcook wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for this! I'm afraid I think I prefer to keep this as-is though. The jaxtyping grammar (and implementation!) is already pretty complicated, so I think I'd prefer to keep it simple. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #378
Can now require that a named or anonymous axes have at least one matching axis by prepending
+, as a complement to the zero or more*.Examples:
Before
Now
Added both positive and negative tests for this in
tests/test_array.py.(Unrelated) The tests
test_numpy_arraylike_work_around_pep484_badnessandtest_union_of_arraylikedid not pass on the main branch even before any changes. This could be a consequence of my environment, but I followed the contributing guide and useduvso I'm unsure of where I could've diverged.