fix(lib): import_hook now correctly handles @no_type_check decorator#393
Merged
Merged
Conversation
jeertmans
force-pushed
the
fix-import-hook
branch
from
June 12, 2026 14:35
8178f92 to
eebf7a3
Compare
Owner
|
LGTM! Thank you for the fix :) We can do a version bump if you'd like, I don't have anything else outstanding for jaxtyping at the moment? |
Contributor
Author
|
Thanks for merging @patrick-kidger! Yes that would be great to release a new version so I can merge my PR without having to ship a temporary hack :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I recently decided to use NVIDIA's warp-lang package for performance reason, and noticed that
beartypewould complain thatwarp's type hints are not PEP-compliant. I then tried to put a@no_type_checkdecorator, but it didn't fix the error.After some investigation, it appears that this bug is caused by the import hook mechanism implemented by
jaxtyping. Fixing it was relatively easy :-)You can run a MWE with
uv run mwe.py.mwe.py:warp_example.py