Fix some issues reported by mago

[DanielBadura]

No description provided.

[DanielBadura]

this is technically a bc-break, but we are using the spread operator already on the result of ParameterResolver::resolve, which means it can be only be working with an int as the key. Also, we typed it like that in our concrete implementation https://github.com/patchlevel/event-sourcing/pull/856/changes#diff-fb59bb4d80adcd4ac904abb097ca2b9c8013a263a00117b936eaecc5f4d3a732L22

[DanielBadura]

getClassName is already typed as T of class-string

[DanielBadura]

phpstan seems to not really pick it up 🤔

[github-actions]

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.081ms (±0.00%)   | 4.248ms (±0.00%)   | -3.94%    | 35.584mb        | 36.102mb   | -1.43%      |
| benchSave10000Events () | 294.457ms (±0.00%) | 351.558ms (±0.00%) | -16.24%   | 35.652mb        | 35.651mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 64.152ms (±0.00%) | 84.674ms (±0.00%) | -24.24%   | 35.544mb        | 35.544mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

CommandToQueryBench
===================

+----------------+-------------------+------------------+-----------+-----------------+------------+-------------+
|                | time (kde mode)                                  | memory                                     |
+----------------+-------------------+------------------+-----------+-----------------+------------+-------------+
| subject        | Tag: <current>    | Tag: base        | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------+-------------------+------------------+-----------+-----------------+------------+-------------+
| benchCreate () | 2.217ms (±0.00%)  | 2.152ms (±0.00%) | +3.00%    | 5.090mb         | 5.034mb    | +1.11%      |
| benchUpdate () | 3.857ms (±0.00%)  | 9.514ms (±0.00%) | -59.46%   | 5.026mb         | 5.026mb    | 0.00%       |
| benchBoth ()   | 10.552ms (±0.00%) | 5.708ms (±0.00%) | +84.87%   | 5.015mb         | 5.015mb    | 0.00%       |
+----------------+-------------------+------------------+-----------+-----------------+------------+-------------+

NoopSubscriptionEngineBench
===========================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 69.994ms (±0.00%) | 62.636ms (±0.00%) | +11.75%   | 47.560mb        | 47.560mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+-------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                    | memory                                     |
+----------------------------------------+--------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+-------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 49.414ms (±0.00%)  | 49.720ms (±0.00%) | -0.61%    | 35.049mb        | 35.049mb   | 0.00%       |
| benchLoad10000Events ()                | 981.400μs (±0.00%) | 1.006ms (±0.00%)  | -2.45%    | 35.049mb        | 35.049mb   | 0.00%       |
+----------------------------------------+--------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 802.700μs (±0.00%) | 819.300μs (±0.00%) | -2.03%    | 34.979mb        | 34.979mb   | 0.00%       |
| benchLoad10000Events ()                | 48.759ms (±0.00%)  | 48.782ms (±0.00%)  | -0.05%    | 34.979mb        | 34.979mb   | 0.00%       |
| benchSave1Event ()                     | 1.119ms (±0.00%)   | 17.938ms (±0.00%)  | -93.76%   | 34.979mb        | 34.979mb   | 0.00%       |
| benchSave10000Events ()                | 205.820ms (±0.00%) | 185.527ms (±0.00%) | +10.94%   | 34.979mb        | 34.979mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.702s (±0.00%)   | 9.110s (±0.00%)    | +28.45%   | 34.979mb        | 34.979mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 3.681s (±0.00%)    | 3.696s (±0.00%)    | -0.43%    | 34.979mb        | 34.979mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 914.300μs (±0.00%) | 919.400μs (±0.00%) | -0.55%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchLoad10000Events ()                | 55.235ms (±0.00%)  | 55.151ms (±0.00%)  | +0.15%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave1Event ()                     | 9.521ms (±0.00%)   | 1.042ms (±0.00%)   | +814.13%  | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Events ()                | 241.073ms (±0.00%) | 239.737ms (±0.00%) | +0.56%    | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000Aggregates ()            | 9.883s (±0.00%)    | 8.506s (±0.00%)    | +16.18%   | 35.206mb        | 35.206mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 3.805s (±0.00%)    | 3.803s (±0.00%)    | +0.06%    | 35.206mb        | 35.206mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 2.474s (±0.00%) | 2.463s (±0.00%) | +0.47%    | 47.560mb        | 47.560mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 999.900μs (±0.00%) | 986.000μs (±0.00%) | +1.41%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchLoad10000Events ()                | 73.587ms (±0.00%)  | 73.136ms (±0.00%)  | +0.62%    | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave1Event ()                     | 2.412ms (±0.00%)   | 4.472ms (±0.00%)   | -46.07%   | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000Events ()                | 211.780ms (±0.00%) | 202.558ms (±0.00%) | +4.55%    | 35.586mb        | 35.586mb   | 0.00%       |
| benchSave10000Aggregates ()            | 17.005s (±0.00%)   | 11.431s (±0.00%)   | +48.76%   | 35.585mb        | 35.585mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 6.890s (±0.00%)    | 6.935s (±0.00%)    | -0.64%    | 36.044mb        | 36.044mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

[DanielBadura]

phpstan seems to have a better type knowledge at this place then mago