fix: use ResetInterface to support Symfony 8.1#317
Merged
DavidBadura merged 1 commit intoJun 2, 2026
Merged
Conversation
Symfony 8.1 moved ServicesResetter from HttpKernel to DependencyInjection, breaking the constructor type hint. ResetInterface from symfony/service-contracts works across Symfony 6.4, 7.x, and 8.x. Fixes: patchlevel#316
Contributor
Author
|
Tested locally against a Symfony 8.1 application (PHP 8.5.6, patchlevel/event-sourcing-bundle 3.16.1): 470 integration tests, 2018 assertions — all green. The fix resolves the TypeError without any regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Symfony 8.1 moved
ServicesResetterfromHttpKernel\DependencyInjectiontoDependencyInjection(symfony/symfony commit). The container now injectsSymfony\Component\DependencyInjection\ServicesResetter. SinceHttpKernel\ServicesResetterextends the DI version (not the other way around), passing the DI version where the HttpKernel subclass is expected causes aTypeErrorat container boot.Fix
Change the type hint from
Symfony\Component\HttpKernel\DependencyInjection\ServicesResettertoSymfony\Contracts\Service\ResetInterface:ServicesResetterhas always implementedResetInterfaceMessenger\EventListener\ResetServicesListenerin 8.1symfony/service-contractsas an explicit dependency (was already transitive viahttp-kernel)The
'services_resetter'service ID inPatchlevelEventSourcingExtensionis unchanged — it remains the stable service ID across all versions.Fixes #316