You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
template: some free-form grades still pass finish, and a forged first failing run passes #422
UAT of #421 at 2f813aa (report nicely-uat-421-2026-10-31.md). #419 and #420 hold on macOS and Linux; just check passes on both; every case of the #418 UAT holds, and its gaps E1 and E2 are closed. Remaining:
Gap: some grades hide in notes. The PR says "Forms that grade still fail, so no grade hides". Under ## Notes, these lines pass just finish: | R1-F1 | really a warn |, Grade: block. The GPS leak is a block for me., This issue is warn-level and should block the release. Only a cell that holds the bare word, code, and "severity … block" are caught. Expected: either the docs (finish-gate.md, rule index) say which forms finish detects and that the reviewer reads the rest, or readinessGrade also catches Grade: and -level, with no false positive on the plain words of template: finish reads common words as severities, and release trusts a hand-written finish in the receipt #419.
Suggestion: the first failing run is only checked for form. A record with the right Scenario commit, the command echo invented, Exit: 1, and an invented assertion passes, and so does an assertion that is a compile error. Consider having just signoff (or finish) rerun the recorded command at the Scenario commit and require a non-zero exit.
Activity
🐛 fix: template: finish fails on a grade in free form, and states its…
✨ feat: template: just signoff runs the first failing run again
🐛 fix: template: an ordinary table cell that ends with block passes f…
✅ test: template: the replay refuses another failing line, and just s…
🐛 fix: template: finish reads None in code in the matrix, and no grad…
🐛 fix: template: only the first assertion of the first failing run is…
✅ test: template: finish reads the first assertion of the first faili…
✅ test: template: finish reads typed build records, as COR-104-T4
✨ feat: template: finish reads typed build records, as COR-104-T4