refactor: Bump jasmine from 6.2.0 to 7.0.0 - #616
Conversation
|
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. Tip
Note Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect. Caution Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe project upgrades its Jasmine development dependency from 6.2.0 to 7.0.0, updates the corresponding locked packages, and nests the random setting under ChangesJasmine upgrade
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to No test-runner compatibility or random-ordering issue was identified in the reviewed changes; they appear ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #616 +/- ##
=======================================
Coverage 97.77% 97.77%
=======================================
Files 2 2
Lines 225 225
=======================================
Hits 220 220
Misses 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Issue
Closes #613
Approach
Upgrades the
jasminedevDependency from 6.2.0 to 7.0.0 (pulls injasmine-core7.0.2 and@jasminejs/reporters1.1.0), and moves the top-levelrandomoption inspec/support/jasmine.jsontoenv.random, because jasmine 7 no longer reads the top-level form.Changes
random); jasmine-core adds a "Temporarily disabled with xdescribe" pending reason for specs disabled withxdescribe--list-not-applicableCLI flag; custom module loaders (loaderconfig option); tested on Node 20 (best effort), 22, 24 and 26notApplicablefunction and spec result status;safariYieldStrategy: "time"is now the default;forbidDuplicateNamesandsafariYieldStrategy: "count"are deprecated; fixes for timer-callbackclearTimeout/clearIntervalhandling andhasOwnPropertycalls on user objectsreset()functionBreaking Changes
randommust now be set asenv.random. The top-level form is silently ignored.alwaysListPendingSpecsandjsLoaderconfig options and theshowColor/alwaysListPendingSpecsmethods have been removed;Jasmine#loadConfigis now async.jasmineRequire,bootandnoGlobalsremoved; globals are installed by thejasminepackage), monkey patching of jasmine internals is blocked, andHtmlReporter,HtmlSpecFilterandjsApiReporterhave been removed.None of the removed APIs are used by this repository, apart from the top-level
randomoption.Code Changes Required
spec/support/jasmine.json: moved"random": trueto"env": { "random": true }. Random order is also the jasmine-core default, so test behavior does not change. The move keeps the explicit setting in effect under jasmine 7.Tasks
Summary by CodeRabbit