Skip to content

refactor: Bump jasmine from 6.2.0 to 7.0.0 - #616

Merged
mtrezza merged 2 commits into
parse-community:masterfrom
mtrezza:refactor/jasmine-7.0.0
Sep 26, 2026
Merged

mtrezza merged 2 commits into
parse-community:masterfrom
mtrezza:refactor/jasmine-7.0.0

Conversation

@mtrezza

@mtrezza mtrezza commented Sep 26, 2026 •

Copy link
Copy Markdown
Member

Issue

Closes #613

Approach

Upgrades the jasmine devDependency from 6.2.0 to 7.0.0 (pulls in jasmine-core 7.0.2 and @jasminejs/reporters 1.1.0), and moves the top-level random option in spec/support/jasmine.json to env.random, because jasmine 7 no longer reads the top-level form.

Changes

  • 6.3.0: Deprecated config properties that duplicate env config (e.g. top-level random); jasmine-core adds a "Temporarily disabled with xdescribe" pending reason for specs disabled with xdescribe
  • 7.0.0: New --list-not-applicable CLI flag; custom module loaders (loader config option); tested on Node 20 (best effort), 22, 24 and 26
  • jasmine-core 7.0.0: New notApplicable function and spec result status; safariYieldStrategy: "time" is now the default; forbidDuplicateNames and safariYieldStrategy: "count" are deprecated; fixes for timer-callback clearTimeout/clearInterval handling and hasOwnProperty calls on user objects
  • jasmine-core 7.0.1 / 7.0.2: Fixes the reported version number and the Node reset() function

Breaking Changes

  • 7.0.0: Config properties that duplicate env config (deprecated in 6.3.0) have been removed, e.g. random must now be set as env.random. The top-level form is silently ignored.
  • 7.0.0: The alwaysListPendingSpecs and jsLoader config options and the showColor / alwaysListPendingSpecs methods have been removed; Jasmine#loadConfig is now async.
  • jasmine-core 7.0.0: Redesigned module system and boot process (jasmineRequire, boot and noGlobals removed; globals are installed by the jasmine package), monkey patching of jasmine internals is blocked, and HtmlReporter, HtmlSpecFilter and jsApiReporter have been removed.

None of the removed APIs are used by this repository, apart from the top-level random option.

Code Changes Required

  • spec/support/jasmine.json: moved "random": true to "env": { "random": true }. Random order is also the jasmine-core default, so test behavior does not change. The move keeps the explicit setting in effect under jasmine 7.

Tasks

  • Upgrade dependency
  • Migrate jasmine config to the jasmine 7 format

Summary by CodeRabbit

  • Chores
    • Updated the project’s test tooling. Test runs continue to use randomized execution.
    • No user-facing features or behavior changed.

@parse-github-assistant

Copy link
Copy Markdown

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

  • Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
  • Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
  • Group code into logical blocks. Add a short comment before each block to explain its purpose.
  • We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
  • Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
  • Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 65f3ffab-5496-437a-843e-b6a50fb67e59

📥 Commits

Reviewing files that changed from the base of the PR and between 8c39a5a and 5b64ec9.

📒 Files selected for processing (3)
  • package-lock.json
  • package.json
  • spec/support/jasmine.json

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The project upgrades its Jasmine development dependency from 6.2.0 to 7.0.0, updates the corresponding locked packages, and nests the random setting under env in the Jasmine configuration.

Changes

Jasmine upgrade

Layer / File(s) Summary
Jasmine dependency and configuration update
package.json, package-lock.json, spec/support/jasmine.json
The Jasmine development dependency changes to 7.0.0. The lockfile updates @jasminejs/reporters to 1.1.0 and jasmine-core to 7.0.2. The Jasmine configuration nests random: true under env.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5b64e

No test-runner compatibility or random-ordering issue was identified in the reviewed changes; they appear ready to merge after normal checks.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title begins with the valid refactor: prefix, uses a capitalized description, and accurately summarizes the Jasmine dependency upgrade.
Linked Issues check ✅ Passed Issue [#613] requires upgrading jasmine from 6.2.0 to 7.0.0. package.json declares jasmine: 7.0.0. The reviewed lockfile also declares jasmine 7.0.0 and updates the related jasmine-core and …
Out of Scope Changes check ✅ Passed The reviewed changes are limited to the Jasmine dependency update, its lockfile metadata, and the Jasmine 7 configuration change. The configuration change directly supports the dependency upgrade beca…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Security Check ✅ Passed No security issue is introduced. The PR changes only the Jasmine development dependency, its lockfile entries, and test configuration. The lockfile keeps integrity hashes and changes only jasmine, jas…
Engage In Review Feedback ✅ Passed No review feedback comments were returned. The current review also produced zero actionable findings. Therefore, there was no feedback to ignore, resolve, implement, or discuss.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.77%. Comparing base (8c39a5a) to head (5b64ec9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #616   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           2        2           
  Lines         225      225           
=======================================
  Hits          220      220           
  Misses          5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mtrezza
mtrezza merged commit 7ec3959 into parse-community:master Sep 26, 2026
13 checks passed
@mtrezza
mtrezza deleted the refactor/jasmine-7.0.0 branch September 26, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant