Skip to content

Fix Clippy lints #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nazar-pc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Clippy lints #820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d16a7
Fix `clippy::ref_patterns` in generated code
nazar-pc Jun 10, 2026
32d8b16
Fix `clippy::semicolon_if_nothing_returne` in generated code
nazar-pc Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions derive/src/encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ fn encode_single_field(
where
__CodecOutputEdqy: #crate_path::Output + ?::core::marker::Sized,
{
#crate_path::Encode::encode_to(&#final_field_variable, __codec_dest_edqy)
#crate_path::Encode::encode_to(&#final_field_variable, __codec_dest_edqy);
}

fn encode(&#i_self) -> #crate_path::alloc::vec::Vec<::core::primitive::u8> {
Expand Down Expand Up @@ -328,14 +328,14 @@ fn impl_encode(data: &Data, type_name: &Ident, crate_path: &syn::Path) -> TokenS

let hinting_names = names.clone();
let hinting = quote_spanned! { f.span() =>
#type_name :: #name { #( ref #hinting_names, )* } => {
#type_name :: #name { #( #hinting_names, )* } => {
#size_hint_fields
}
};

let encoding_names = names.clone();
let encoding = quote_spanned! { f.span() =>
#type_name :: #name { #( ref #encoding_names, )* } => {
#type_name :: #name { #( #encoding_names, )* } => {
#[allow(clippy::unnecessary_cast)]
#dest.push_byte((#index) as ::core::primitive::u8);
#encode_fields
Expand All @@ -361,14 +361,14 @@ fn impl_encode(data: &Data, type_name: &Ident, crate_path: &syn::Path) -> TokenS

let hinting_names = names.clone();
let hinting = quote_spanned! { f.span() =>
#type_name :: #name ( #( ref #hinting_names, )* ) => {
#type_name :: #name ( #( #hinting_names, )* ) => {
#size_hint_fields
}
};

let encoding_names = names.clone();
let encoding = quote_spanned! { f.span() =>
#type_name :: #name ( #( ref #encoding_names, )* ) => {
#type_name :: #name ( #( #encoding_names, )* ) => {
#[allow(clippy::unnecessary_cast)]
#dest.push_byte((#index) as ::core::primitive::u8);
#encode_fields
Expand Down Expand Up @@ -403,7 +403,7 @@ fn impl_encode(data: &Data, type_name: &Ident, crate_path: &syn::Path) -> TokenS

let hinting = quote! {
// The variant index uses 1 byte.
1_usize + match *#self_ {
1_usize + match #self_ {
#( #recurse_hinting )*,
_ => 0_usize,
}
Expand All @@ -414,7 +414,7 @@ fn impl_encode(data: &Data, type_name: &Ident, crate_path: &syn::Path) -> TokenS

let encoding = quote! {
#const_eval_check
match *#self_ {
match #self_ {
#( #recurse_encoding )*,
_ => (),
}
Expand Down