Skip to content

panorama: declare the Panorama calls the layout library makes - #128

Merged
paralin merged 1 commit into
masterfrom
layout-panorama-globals
Nov 15, 2026
Merged

paralin merged 1 commit into
masterfrom
layout-panorama-globals

Conversation

@paralin

@paralin paralin commented Nov 15, 2026

Copy link
Copy Markdown
Owner

The layout library calls $.GetContextPanel, $.Msg and $.RegisterForUnhandledEvent, which only src/panorama.d.ts declared. That file is not among the vendored sources, so a consumer compiling a vendored layout.ts type-checked it against whatever $ the consumer declared, or none, and failed with errors about members of $ that do not exist.

layout.ts now declares the part of $ it calls, in its own module scope, so it type-checks the same in this repository and in a vendored copy. A triple-slash reference to panorama.d.ts would have done the same, but the lint forbids them.

The layout library calls $.GetContextPanel, $.Msg and
$.RegisterForUnhandledEvent, which only src/panorama.d.ts declared. That
file is not among the vendored sources, so a consumer compiling a vendored
layout.ts type-checked it against whatever $ the consumer declared, or none,
and failed with errors about members of $ that do not exist.

layout.ts now declares the part of $ it calls, in its own module scope, so
it type-checks the same in this repository and in a vendored copy.

Signed-off-by: Christian Stewart <christian@aperture.us>
@paralin
paralin merged commit f038729 into master Nov 15, 2026
7 checks passed
@paralin
paralin deleted the layout-panorama-globals branch November 15, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant