Skip to content

gameinterop: never withhold an ability a player's client may hold (on v0.1.80, for CI) - #125

Merged
paralin merged 1 commit into
masterfrom
patch/v0.1.80-owner-guard-held
Nov 14, 2026
Merged

paralin merged 1 commit into
masterfrom
patch/v0.1.80-owner-guard-held

Conversation

@paralin

@paralin paralin commented Nov 14, 2026

Copy link
Copy Markdown
Owner

This is cf154f4 (branch fix/owner-guard-held) cherry-picked onto tag v0.1.80 as a43e8a1, opened as a draft so CI builds and tests it. CI runs only on pull requests. The ability owner guard from v0.1.77 clears the transmit bit of an ability whose owner is not live or not sent, even when the client already holds that ability. The server then keeps updating an entity the client has dropped, and the client closes with "CopyExistingEntity: missing client entity". HeldAbilities remembers per slot what each client was sent, so the guard withholds only from a client that cannot hold the ability. This is not for merge as is and no tag is cut from it. It is the candidate for a v0.1.80 patch release if the evidence holds.

The ability owner guard cleared an ability's transmit bit whenever its owner
was not live or not sent in the same update. That keeps a joining client from
creating an ability without its owner, but it also cleared the bit for an
ability the client already held. The server still counts such an entity as
held and keeps sending deltas, while the client drops it, which closes the
client with "CopyExistingEntity: missing client entity".

Add HeldAbilities, which records per player slot every ability the guard let
through, by index and serial. A record ends when the ability leaves the world,
another entity takes its index, or the slot's connection ends or changes
generation (from ConnectionTracker). The guard now withholds an ownerless
ability only from a client that cannot hold it, and logs each ability it keeps
sending for that reason under the same throttle as the withhold line. A slot
the connection tracker does not know falls back to the old behaviour.

Signed-off-by: Christian Stewart <christian@aperture.us>
(cherry picked from commit cf154f4)
@paralin
paralin marked this pull request as ready for review November 14, 2026 19:49
@paralin
paralin merged commit ea5897c into master Nov 14, 2026
7 checks passed
@paralin
paralin deleted the patch/v0.1.80-owner-guard-held branch November 14, 2026 19:50
@paralin
paralin restored the patch/v0.1.80-owner-guard-held branch November 14, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant