fix: enforce strict JSON numbers - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AddHttpto useJsonNumberHandling.Strictfor HTTP JSON serialization.Why
ASP.NET Core web defaults allow numbers to be read from JSON strings. In .NET 10, OpenAPI 3.1 reflects that setting as
integer | stringandnumber | string, which prevents clients such as Kiota from generating scalar numeric properties.How to verify
All 75 package tests pass. The equivalent setting was also applied temporarily to the Tactical Heroes API host and all 487 solution tests passed.
Compatibility
integerornumber.