Leverage font-display: swap mode of Google fonts#26
Open
AramZS wants to merge 1 commit intopages-themes:masterfrom
Open
Leverage font-display: swap mode of Google fonts#26AramZS wants to merge 1 commit intopages-themes:masterfrom
AramZS wants to merge 1 commit intopages-themes:masterfrom
Conversation
For performance reasons it is best to use `font-display: swap` and Google Fonts supports this via a URL param. See: https://web.dev/font-display/?utm_source=lighthouse&utm_medium=lr#google-fonts
|
Welcome! Congrats on your first pull request to the Dinky theme. If you haven't already, please be sure to check out the contributing guidelines. |
UltiRequiem
approved these changes
Mar 16, 2022
UltiRequiem
left a comment
UltiRequiem
left a comment
There was a problem hiding this comment.
Good work!
Are you able to make a PR for each repo on https://github.com/pages-themes ?
If not you are not, is it okey if I do it?
Author
I'm not familiar enough with the other themes to make that suggestion, but if you are and think they need it please go ahead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For performance reasons it is best to use
font-display: swapand Google Fonts supports this via a URL param. See: https://web.dev/font-display/?utm_source=lighthouse&utm_medium=lr#google-fonts for more info.I think it would be wise to add this to the template as the lack of it gets a page a significant ding in web performance measurement.